starred/librespot

Fork 0

mirror of https://github.com/librespot-org/librespot.git synced 2026-04-27 08:15:50 +03:00

[GH-ISSUE #269] Search proto file is broken #181

New issue

Closed

opened 2026-02-27 19:29:16 +03:00 by kerem · 3 comments

kerem commented

2026-02-27 19:29:16 +03:00

Owner

Originally created by @devgianlu on GitHub (Nov 23, 2018).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/269

This is clearly broken. It looks like import "metadata.proto"; is missing and there are some repeated fields number.

protoc says:

search.proto:16:35: Field number 2 has already been used in "SearchRequest" by field "type".
search.proto:17:30: Field number 3 has already been used in "SearchRequest" by field "limit".
search.proto:18:27: Field number 4 has already been used in "SearchRequest" by field "offset".
search.proto:19:32: Field number 5 has already been used in "SearchRequest" by field "did_you_mean".
search.proto:25:14: "Image" is not defined.
search.proto:31:14: "Image" is not defined.
search.proto:37:14: "Track" is not defined.
search.proto:38:14: "Album" is not defined.
search.proto:39:14: "Artist" is not defined.

Originally created by @devgianlu on GitHub (Nov 23, 2018). Original GitHub issue: https://github.com/librespot-org/librespot/issues/269 [This](https://github.com/librespot-org/librespot/blob/master/protocol/proto/search.proto) is clearly broken. It looks like `import "metadata.proto";` is missing and there are some repeated fields number. `protoc` says: ``` search.proto:16:35: Field number 2 has already been used in "SearchRequest" by field "type". search.proto:17:30: Field number 3 has already been used in "SearchRequest" by field "limit". search.proto:18:27: Field number 4 has already been used in "SearchRequest" by field "offset". search.proto:19:32: Field number 5 has already been used in "SearchRequest" by field "did_you_mean". search.proto:25:14: "Image" is not defined. search.proto:31:14: "Image" is not defined. search.proto:37:14: "Track" is not defined. search.proto:38:14: "Album" is not defined. search.proto:39:14: "Artist" is not defined. ```

kerem closed this issue

2026-02-27 19:29:17 +03:00

kerem commented

2026-02-27 19:29:17 +03:00

Author

Owner

@sashahilton00 commented on GitHub (Dec 4, 2018):

we never ended up implementing search, my guess is things have changed in the past 3 years. will probably require one to pull apart the android app to get the latest definitions if you want to fix it.

@sashahilton00 commented on GitHub (Dec 4, 2018): we never ended up implementing search, my guess is things have changed in the past 3 years. will probably require one to pull apart the android app to get the latest definitions if you want to fix it.

kerem commented

2026-02-27 19:29:17 +03:00

Author

Owner

@ashthespy commented on GitHub (Dec 4, 2018):

The golang port also a working search.proto.

@ashthespy commented on GitHub (Dec 4, 2018): The golang port also a working [`search.proto`](https://github.com/librespot-org/librespot-golang/blob/master/src/Spotify/search.proto).

kerem commented

2026-02-27 19:29:17 +03:00

Author

Owner

@devgianlu commented on GitHub (Dec 4, 2018):

Thank you, I'll leave up to you whether to update it in this repository.

@devgianlu commented on GitHub (Dec 4, 2018): Thank you, I'll leave up to you whether to update it in this repository.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#181

No description provided.

Rows
Columns