starred/librespot

Fork 0

mirror of https://github.com/librespot-org/librespot.git synced 2026-04-27 08:15:50 +03:00

[GH-ISSUE #243] Ignored contrib folder causes Raspberry Pi build to fail #164

New issue

Closed

opened 2026-02-27 19:29:10 +03:00 by kerem · 5 comments

kerem commented

2026-02-27 19:29:10 +03:00

Owner

Originally created by @bricedp on GitHub (Aug 17, 2018).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/243

As a result of the recently merged #237, the contrib folder is now ignored by Docker. While most builds do not use this folder, the Raspberry Pi build uses the file docker-build-pi-armv6hf.sh, which is in that folder. Running the Docker image fails like so:

$ docker run -v /tmp/librespot-build:/build librespot-cross contrib/docker-build-pi-armv6hf.sh
docker: Error response from daemon: OCI runtime create failed: container_linux.go:348: starting container process caused "exec: \"contrib/docker-build-pi-armv6hf.sh\": stat contrib/docker-build-pi-armv6hf.sh: no such file or directory": unknown.
ERRO[0001] error waiting for container: context canceled

When inspecting the image, the file is (as expected) not found:

root@4205aa4799e1:/src# pwd         
/src
root@4205aa4799e1:/src# find contrib
contrib
root@4205aa4799e1:/src# ls -l contrib/docker-build-pi-armv6hf.sh
ls: cannot access 'contrib/docker-build-pi-armv6hf.sh': No such file or directory

Either the contrib folder should be removed from the .dockerignore file, or the build script should be moved elsewhere in the directory structure so that it can be included in the built image. If it is moved, the corresponding instructions in the Dockerfile need to be updated as well.

Originally created by @bricedp on GitHub (Aug 17, 2018). Original GitHub issue: https://github.com/librespot-org/librespot/issues/243 As a result of the recently merged #237, the contrib folder is now ignored by Docker. While most builds do not use this folder, the Raspberry Pi build uses the file docker-build-pi-armv6hf.sh, which is in that folder. Running the Docker image fails like so: $ docker run -v /tmp/librespot-build:/build librespot-cross contrib/docker-build-pi-armv6hf.sh docker: Error response from daemon: OCI runtime create failed: container_linux.go:348: starting container process caused "exec: \"contrib/docker-build-pi-armv6hf.sh\": stat contrib/docker-build-pi-armv6hf.sh: no such file or directory": unknown. ERRO[0001] error waiting for container: context canceled When inspecting the image, the file is (as expected) not found: root@4205aa4799e1:/src# pwd /src root@4205aa4799e1:/src# find contrib contrib root@4205aa4799e1:/src# ls -l contrib/docker-build-pi-armv6hf.sh ls: cannot access 'contrib/docker-build-pi-armv6hf.sh': No such file or directory Either the contrib folder should be removed from the .dockerignore file, or the build script should be moved elsewhere in the directory structure so that it can be included in the built image. If it is moved, the corresponding instructions in the Dockerfile need to be updated as well.

kerem closed this issue

2026-02-27 19:29:11 +03:00

kerem commented

2026-02-27 19:29:11 +03:00

Author

Owner

@bricedp commented on GitHub (Aug 17, 2018):

Similarly, the default Dockerfile command (CMD ["/src/contrib/docker-build.sh"]) uses the file docker-build.sh, which is also in the contrib directory.

$ docker run librespot-cross
docker: Error response from daemon: OCI runtime create failed: container_linux.go:348: starting container process caused "exec: \"/src/contrib/docker-build.sh\": stat /src/contrib/docker-build.sh: no such file or directory": unknown.
ERRO[0002] error waiting for container: context canceled

@bricedp commented on GitHub (Aug 17, 2018): Similarly, the default Dockerfile command (`CMD ["/src/contrib/docker-build.sh"]`) uses the file docker-build.sh, which is also in the contrib directory. $ docker run librespot-cross docker: Error response from daemon: OCI runtime create failed: container_linux.go:348: starting container process caused "exec: \"/src/contrib/docker-build.sh\": stat /src/contrib/docker-build.sh: no such file or directory": unknown. ERRO[0002] error waiting for container: context canceled

kerem commented

2026-02-27 19:29:11 +03:00

Author

Owner

@bilak commented on GitHub (Aug 30, 2018):

this commit just broken the build. Remove contrib from .dockerignore and you are good to go.

@bilak commented on GitHub (Aug 30, 2018): [this commit](https://github.com/librespot-org/librespot/commit/861515e208ff3739397887cdc8b02d5816f84719) just broken the build. Remove contrib from .dockerignore and you are good to go.

kerem commented

2026-02-27 19:29:11 +03:00

Author

Owner

@ComlOnline commented on GitHub (Sep 1, 2018):

Sorry for not catching that before merging

@ComlOnline commented on GitHub (Sep 1, 2018): Sorry for not catching that before merging

kerem commented

2026-02-27 19:29:11 +03:00

Author

Owner

@sashahilton00 commented on GitHub (Nov 3, 2018):

will revert that, one sec

@sashahilton00 commented on GitHub (Nov 3, 2018): will revert that, one sec

kerem commented

2026-02-27 19:29:11 +03:00

Author

Owner

@sashahilton00 commented on GitHub (Nov 3, 2018):

Removed contrib from .dockerignore in github.com/librespot-org/librespot@0331a7f592, should now work.

@sashahilton00 commented on GitHub (Nov 3, 2018): Removed contrib from `.dockerignore` in https://github.com/librespot-org/librespot/commit/0331a7f592a8d7086cc211de1ce8e648356b68d0, should now work.

kerem referenced this issue

2026-02-27 20:00:05 +03:00

[PR #164] [MERGED] Issue 130 #822

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#164

No description provided.

Rows
Columns