[PR #1638] [MERGED] make SpotifyUri::to_uri() infallible #1473

New issue

Closed

opened 2026-02-27 20:02:35 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:02:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1638
Author: @wfraser
Created: 11/15/2025
Status: ✅ Merged
Merged: 11/15/2025
Merged by: @photovoltex

Base: dev ← Head: spotifyuri-infallible

📝 Commits (1)

67d4532 make SpotifyUri::to_uri() infallible

📊 Changes

8 files changed (+17 additions, -19 deletions)

View changed files

📝 CHANGELOG.md (+1 -1)
📝 connect/src/spirc.rs (+1 -1)
📝 connect/src/state/context.rs (+1 -1)
📝 connect/src/state/tracks.rs (+1 -1)
📝 core/src/spclient.rs (+2 -2)
📝 core/src/spotify_uri.rs (+8 -10)
📝 metadata/src/audio/item.rs (+2 -2)
📝 playback/src/player.rs (+1 -1)

📄 Description

Tiny follow-up to #1635

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1638 **Author:** [@wfraser](https://github.com/wfraser) **Created:** 11/15/2025 **Status:** ✅ Merged **Merged:** 11/15/2025 **Merged by:** [@photovoltex](https://github.com/photovoltex) **Base:** `dev` ← **Head:** `spotifyuri-infallible` --- ### 📝 Commits (1) - [`67d4532`](https://github.com/librespot-org/librespot/commit/67d4532b82ec9f6bc0754c5a4ac77cfa5ab96a06) make SpotifyUri::to_uri() infallible ### 📊 Changes **8 files changed** (+17 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -1) 📝 `connect/src/spirc.rs` (+1 -1) 📝 `connect/src/state/context.rs` (+1 -1) 📝 `connect/src/state/tracks.rs` (+1 -1) 📝 `core/src/spclient.rs` (+2 -2) 📝 `core/src/spotify_uri.rs` (+8 -10) 📝 `metadata/src/audio/item.rs` (+2 -2) 📝 `playback/src/player.rs` (+1 -1) </details> ### 📄 Description Tiny follow-up to #1635 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:02:35 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1473

No description provided.

Rows
Columns