[PR #1637] chore: remove async-trait #1471

New issue

Open

opened 2026-02-27 20:02:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:02:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1637
Author: @photovoltex
Created: 11/14/2025
Status: 🔄 Open

Base: dev ← Head: remove-async-trait

📝 Commits (2)

8c67d7b chore: remove async-trait
7ace4d0 chore: update CHANGELOG

📊 Changes

12 files changed (+24 additions, -21 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 Cargo.lock (+0 -1)
📝 metadata/Cargo.toml (+0 -1)
📝 metadata/src/album.rs (+0 -1)
📝 metadata/src/artist.rs (+0 -1)
📝 metadata/src/episode.rs (+0 -1)
📝 metadata/src/lib.rs (+23 -11)
📝 metadata/src/playlist/annotation.rs (+0 -1)
📝 metadata/src/playlist/list.rs (+0 -1)
📝 metadata/src/request.rs (+0 -1)
📝 metadata/src/show.rs (+0 -1)
📝 metadata/src/track.rs (+0 -1)

📄 Description

Removes the async-trait crate as our MSRV is higher then 1.75, which introduced the feature.

This change is not necessary and sadly doesn't remove async-trait from our build chain completely, as zbus still includes it. I looked into removing async-trait from zbus... but they use it so much, that removing it is a huge task itself.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1637 **Author:** [@photovoltex](https://github.com/photovoltex) **Created:** 11/14/2025 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `remove-async-trait` --- ### 📝 Commits (2) - [`8c67d7b`](https://github.com/librespot-org/librespot/commit/8c67d7b27a352b95d6a042b0985a26ba43fc4455) chore: remove async-trait - [`7ace4d0`](https://github.com/librespot-org/librespot/commit/7ace4d0b507b92c79c6d0cd8d546976b1a2df8bf) chore: update CHANGELOG ### 📊 Changes **12 files changed** (+24 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `Cargo.lock` (+0 -1) 📝 `metadata/Cargo.toml` (+0 -1) 📝 `metadata/src/album.rs` (+0 -1) 📝 `metadata/src/artist.rs` (+0 -1) 📝 `metadata/src/episode.rs` (+0 -1) 📝 `metadata/src/lib.rs` (+23 -11) 📝 `metadata/src/playlist/annotation.rs` (+0 -1) 📝 `metadata/src/playlist/list.rs` (+0 -1) 📝 `metadata/src/request.rs` (+0 -1) 📝 `metadata/src/show.rs` (+0 -1) 📝 `metadata/src/track.rs` (+0 -1) </details> ### 📄 Description Removes the `async-trait` crate as our MSRV is higher then 1.75, which introduced the feature. > This change is not necessary and sadly doesn't remove `async-trait` from our build chain completely, as `zbus` still includes it. I looked into removing `async-trait` from `zbus`... but they use it so much, that removing it is a huge task itself. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem added the

pull-request

label

2026-02-27 20:02:34 +03:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1471

No description provided.

Rows
Columns