[PR #1634] CI: Improve feature checking for binary #1469

New issue

Open

opened 2026-02-27 20:02:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:02:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1634
Author: @photovoltex
Created: 11/11/2025
Status: 🔄 Open

Base: dev ← Head: ci/improve-feature-testing

📝 Commits (8)

02f4199 ci: improve feature checking
bc9b12f ci: separate between cross and linux only features
3abe3b7 ci: install required packages for windows, cache gstreamer
2704eb9 ci: mark rodiojack-backend feature as "not windows, yet"
a771e11 ci: exclude with-dns-sd feature from windows build
179672c ci: only execute windows on default branch
b6f4134 ci: optional windows execution in PR-CI
1d30fcc ci: wrong assumption, better label naming

📊 Changes

2 files changed (+47 additions, -19 deletions)

View changed files

📝 .github/workflows/build.yml (+43 -15)
📝 Cargo.toml (+4 -4)

📄 Description

Simple adjustment to the ci that checks all tls features and each-feature with native-tls.

We previously had --each-feature executions, but if --include-features is provided, each-feature will only execute for the features provided by that flag. Because of that we only tested rustls-tls-native-roots and native-tls.

This should hopefully prevent compilation issues like:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1634 **Author:** [@photovoltex](https://github.com/photovoltex) **Created:** 11/11/2025 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `ci/improve-feature-testing` --- ### 📝 Commits (8) - [`02f4199`](https://github.com/librespot-org/librespot/commit/02f419994255960dfc702c3d41c246350e2639ac) ci: improve feature checking - [`bc9b12f`](https://github.com/librespot-org/librespot/commit/bc9b12fd1d3759228f7c108b867ee976cf805d5e) ci: separate between cross and linux only features - [`3abe3b7`](https://github.com/librespot-org/librespot/commit/3abe3b73108a130a76bb0a9cc769a1c84f2d7a49) ci: install required packages for windows, cache gstreamer - [`2704eb9`](https://github.com/librespot-org/librespot/commit/2704eb920dedd6ee58f6382f55cd13acb875f02c) ci: mark `rodiojack-backend` feature as "not windows, yet" - [`a771e11`](https://github.com/librespot-org/librespot/commit/a771e11c389e05a751ed3e3804f95289e89fe4d6) ci: exclude `with-dns-sd` feature from windows build - [`179672c`](https://github.com/librespot-org/librespot/commit/179672cea4e5512bf4a8a5a0440fa6c2b1b92317) ci: only execute windows on default branch - [`b6f4134`](https://github.com/librespot-org/librespot/commit/b6f41341fadf5c3f18b23ae98bffd1f4a56dd3ec) ci: optional windows execution in PR-CI - [`1d30fcc`](https://github.com/librespot-org/librespot/commit/1d30fccc8161c63eca7402450cd862cca1ef8ef4) ci: wrong assumption, better label naming ### 📊 Changes **2 files changed** (+47 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build.yml` (+43 -15) 📝 `Cargo.toml` (+4 -4) </details> ### 📄 Description Simple adjustment to the ci that checks all tls features and each-feature with native-tls. We previously had `--each-feature` executions, but if `--include-features` is provided, each-feature will only execute for the features provided by that flag. Because of that we only tested `rustls-tls-native-roots` and `native-tls`. This should hopefully prevent compilation issues like: - https://github.com/librespot-org/librespot/pull/1600 - https://github.com/librespot-org/librespot/pull/1630 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem added the

pull-request

label

2026-02-27 20:02:34 +03:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1469

No description provided.

Rows
Columns