[PR #1630] [MERGED] fix: Fix build failure with passthrough-decoder #1468

New issue

Closed

opened 2026-02-27 20:02:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:02:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1630
Author: @SapiensAnatis
Created: 11/9/2025
Status: ✅ Merged
Merged: 11/9/2025
Merged by: @roderickvd

Base: dev ← Head: fix/passthrough-decoder

📝 Commits (1)

efa17b7 fix: Fix build failure with passthrough-decoder

📊 Changes

1 file changed (+7 additions, -9 deletions)

View changed files

📝 playback/src/player.rs (+7 -9)

📄 Description

Fix a build failure with passthrough-decoder enabled which resulted from the change in signature of SymphoniaDecoder::new. We need to update the code path where the feature is enabled but the passthrough decoder is disabled via runtime config, to use the new signature.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1630 **Author:** [@SapiensAnatis](https://github.com/SapiensAnatis) **Created:** 11/9/2025 **Status:** ✅ Merged **Merged:** 11/9/2025 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `fix/passthrough-decoder` --- ### 📝 Commits (1) - [`efa17b7`](https://github.com/librespot-org/librespot/commit/efa17b7990706797bb41901413dff806eb75cff1) fix: Fix build failure with passthrough-decoder ### 📊 Changes **1 file changed** (+7 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `playback/src/player.rs` (+7 -9) </details> ### 📄 Description Fix a build failure with passthrough-decoder enabled which resulted from the change in signature of SymphoniaDecoder::new. We need to update the code path where the feature is enabled but the passthrough decoder is disabled via runtime config, to use the new signature. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:02:34 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1468

No description provided.

Rows
Columns