[PR #1594] [MERGED] Fix cross compilation (add required TLS backend selection) #1447

New issue

Closed

opened 2026-02-27 20:02:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:02:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1594
Author: @starypatyk
Created: 9/21/2025
Status: ✅ Merged
Merged: 9/22/2025
Merged by: @roderickvd

Base: dev ← Head: fix_cross_compile

📝 Commits (1)

7e1c321 Fix cross compilation (add required TLS backend selection)

📊 Changes

3 files changed (+9 additions, -9 deletions)

View changed files

📝 contrib/Dockerfile (+4 -4)
📝 contrib/cross-compile-armv6hf/docker-build.sh (+1 -1)
📝 contrib/docker-build.sh (+4 -4)

📄 Description

After recent changes the TLS back-end must be explicitly selected when --no-default-features flag is used.

The provided cross-compilation scripts were not updated accordingly and the cross build failed as described in #1573.

In this PR I propose to cross build with rustls-tls-native-roots.

With these changes in place, I have been able to build all available targets. I have verified that the following targets run successfully: x86_64 (PC), aarch64 (RPi 3), armhf (RPi 3) and armv6hf (RPi 1). The armel target built OK, but I have not been able to verify it.

The selection of features used in these scripts (audio, mDNS , TLS) depends on the use case, but I think it is better to have at least a single set that is known to work.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1594 **Author:** [@starypatyk](https://github.com/starypatyk) **Created:** 9/21/2025 **Status:** ✅ Merged **Merged:** 9/22/2025 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `fix_cross_compile` --- ### 📝 Commits (1) - [`7e1c321`](https://github.com/librespot-org/librespot/commit/7e1c3219e96f7d2e9ac8013e3ea4a03b2a9d4252) Fix cross compilation (add required TLS backend selection) ### 📊 Changes **3 files changed** (+9 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `contrib/Dockerfile` (+4 -4) 📝 `contrib/cross-compile-armv6hf/docker-build.sh` (+1 -1) 📝 `contrib/docker-build.sh` (+4 -4) </details> ### 📄 Description After recent changes the TLS back-end must be explicitly selected when `--no-default-features` flag is used. The provided cross-compilation scripts were not updated accordingly and the cross build failed as described in #1573. In this PR I propose to cross build with `rustls-tls-native-roots`. With these changes in place, I have been able to build all available targets. I have verified that the following targets run successfully: `x86_64` (PC), `aarch64` (RPi 3), `armhf` (RPi 3) and `armv6hf` (RPi 1). The `armel` target built OK, but I have not been able to verify it. The selection of features used in these scripts (audio, mDNS , TLS) depends on the use case, but I think it is better to have at least a single set that is known to work. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:02:29 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1447

No description provided.

Rows
Columns