[PR #1555] [MERGED] Fix: Delete the connect state only on spirc shutdown #1437

New issue

Closed

opened 2026-02-27 20:02:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:02:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1555
Author: @photovoltex
Created: 8/26/2025
Status: ✅ Merged
Merged: 8/27/2025
Merged by: @photovoltex

Base: dev ← Head: fix/delete-state-only-on-shutdown

📝 Commits (3)

fc6accf fix: only delete the state on shutdown
a9416ac chore: update changelog
7620d62 Merge branch 'dev' into fix/delete-state-only-on-shutdown

📊 Changes

2 files changed (+6 additions, -6 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 connect/src/spirc.rs (+5 -6)

📄 Description

In #1551 @samcook encountered an unexpected behavior during reconnecting.

The issue happens because the reconnect is initiated via zeroconf instead of using the connect interface, aka in the disconnect handling was a major issue where the state itself was deleted. This should only happen when shutting down the dealer so that the dealer can still receive requests and updates.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1555 **Author:** [@photovoltex](https://github.com/photovoltex) **Created:** 8/26/2025 **Status:** ✅ Merged **Merged:** 8/27/2025 **Merged by:** [@photovoltex](https://github.com/photovoltex) **Base:** `dev` ← **Head:** `fix/delete-state-only-on-shutdown` --- ### 📝 Commits (3) - [`fc6accf`](https://github.com/librespot-org/librespot/commit/fc6accfa6ae6c66f0de0fe72fdbb1615284e501f) fix: only delete the state on shutdown - [`a9416ac`](https://github.com/librespot-org/librespot/commit/a9416accfdf592660cbcdc94ac6233891fc9797d) chore: update changelog - [`7620d62`](https://github.com/librespot-org/librespot/commit/7620d6222542c0f7085bdaaa2d0e1cd2e57b0e4d) Merge branch 'dev' into fix/delete-state-only-on-shutdown ### 📊 Changes **2 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `connect/src/spirc.rs` (+5 -6) </details> ### 📄 Description In #1551 @samcook encountered an unexpected behavior during reconnecting. The issue happens because the reconnect is initiated via zeroconf instead of using the connect interface, aka in the disconnect handling was a major issue where the state itself was deleted. This should only happen when shutting down the dealer so that the dealer can still receive requests and updates. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:02:26 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1437

No description provided.

Rows
Columns