[PR #1552] [MERGED] Fix: Fixup how the headers are set in `spclient` to prevent deleting headers #1435

New issue

Closed

opened 2026-02-27 20:02:26 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:02:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1552
Author: @photovoltex
Created: 8/25/2025
Status: ✅ Merged
Merged: 8/26/2025
Merged by: @roderickvd

Base: dev ← Head: fix/fixup-missing-events

📝 Commits (2)

941a1d4 fix: fixup missing event
6a8b81e chore: update changelog

📊 Changes

2 files changed (+7 additions, -2 deletions)

View changed files

📝 CHANGELOG.md (+2 -0)
📝 core/src/spclient.rs (+5 -2)

📄 Description

Instead of setting the header later I overwrite the headers in a loop. insert seems to replace the existing keys, so the headers given from the outside are still prioritized, and headers set in the builder are not removed.

Fixes #1551

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1552 **Author:** [@photovoltex](https://github.com/photovoltex) **Created:** 8/25/2025 **Status:** ✅ Merged **Merged:** 8/26/2025 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `fix/fixup-missing-events` --- ### 📝 Commits (2) - [`941a1d4`](https://github.com/librespot-org/librespot/commit/941a1d43e0d5168a4bea18ee1da3de09d66dcbaf) fix: fixup missing event - [`6a8b81e`](https://github.com/librespot-org/librespot/commit/6a8b81efe99999ba11bedb7b9144ab0681f431e8) chore: update changelog ### 📊 Changes **2 files changed** (+7 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+2 -0) 📝 `core/src/spclient.rs` (+5 -2) </details> ### 📄 Description Instead of setting the header later I overwrite the headers in a loop. `insert` seems to replace the existing keys, so the headers given from the outside are still prioritized, and headers set in the builder are not removed. Fixes #1551 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:02:26 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1435

No description provided.

Rows
Columns

[PR #1552] [MERGED] Fix: Fixup how the headers are set in spclient to prevent deleting headers #1435

📋 Pull Request Information

📝 Commits (2)

📊 Changes

📄 Description

[PR #1552] [MERGED] Fix: Fixup how the headers are set in `spclient` to prevent deleting headers #1435