[PR #1541] [MERGED] feat: native TLS #1431

New issue

Closed

opened 2026-02-27 20:02:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:02:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1541
Author: @roderickvd
Created: 8/15/2025
Status: ✅ Merged
Merged: 8/19/2025
Merged by: @roderickvd

Base: dev ← Head: feat/native-tls

📝 Commits (10+)

f09ab81 feat(deps): move to native TLS on all platforms
6dd9bad fix: update apt after dpkg architecture add
e7a053a ci: refactor workflows with cross-compilation and best practices
28562c2 fix: vendorize openssl on riscv64gc
0b6de6a fix: vendorize openssl on riscv64gc
c092d23 feat: native-tls and rustls-tls features with rustls platform verifier
c6cf191 fix: native-tls and rustls-tls are mutually exclusive
4fd9db1 ci: always include one tls backend
606f9dc refactor: TLS feature handling and CI build steps
2103965 refactor: document TLS backend options and propagate workspace fields

📊 Changes

31 files changed (+928 additions, -577 deletions)

View changed files

📝 .devcontainer/Dockerfile (+0 -1)
📝 .devcontainer/Dockerfile.alpine (+0 -1)
📝 .devcontainer/devcontainer.json (+15 -19)
➕ .github/workflows/build.yml (+99 -0)
➕ .github/workflows/cross-compile.yml (+78 -0)
➕ .github/workflows/quality.yml (+79 -0)
➖ .github/workflows/test.yml (+0 -281)
📝 CHANGELOG.md (+1 -1)
📝 COMPILING.md (+65 -6)
📝 Cargo.lock (+190 -22)
📝 Cargo.toml (+147 -77)
➕ Cross.toml (+12 -0)
📝 README.md (+6 -4)
📝 audio/Cargo.toml (+15 -9)
📝 audio/src/fetch/mod.rs (+4 -6)
📝 connect/Cargo.toml (+17 -17)
📝 core/Cargo.toml (+44 -32)
📝 core/src/http_client.rs (+14 -9)
📝 discovery/Cargo.toml (+20 -16)
📝 discovery/examples/discovery.rs (+1 -1)

...and 11 more files

📄 Description

Maybe we're lucky and the latest Rust ecosystem is allowing us to switch to native TLS easily.
This PR switches from rustls and ring to native TLS on all platforms.

Fixes #1158

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1541 **Author:** [@roderickvd](https://github.com/roderickvd) **Created:** 8/15/2025 **Status:** ✅ Merged **Merged:** 8/19/2025 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `feat/native-tls` --- ### 📝 Commits (10+) - [`f09ab81`](https://github.com/librespot-org/librespot/commit/f09ab8115a98279a534f997aebd248e1ca50e7ce) feat(deps): move to native TLS on all platforms - [`6dd9bad`](https://github.com/librespot-org/librespot/commit/6dd9bad470ba8798150a04b14911cdb64009f361) fix: update apt after dpkg architecture add - [`e7a053a`](https://github.com/librespot-org/librespot/commit/e7a053a8ae76e1a1c2a788b90a1ea13a8ed32ae4) ci: refactor workflows with cross-compilation and best practices - [`28562c2`](https://github.com/librespot-org/librespot/commit/28562c238c1b54e552dea86aba561ed361ac7bba) fix: vendorize openssl on riscv64gc - [`0b6de6a`](https://github.com/librespot-org/librespot/commit/0b6de6a5a7a7554df5bb2ebbbdd881fd2c3212e3) fix: vendorize openssl on riscv64gc - [`c092d23`](https://github.com/librespot-org/librespot/commit/c092d2325efee16abc06002dcf43d0681a8b8da0) feat: native-tls and rustls-tls features with rustls platform verifier - [`c6cf191`](https://github.com/librespot-org/librespot/commit/c6cf191871509dd8d0fcc3c4d320e9e50c6377c3) fix: native-tls and rustls-tls are mutually exclusive - [`4fd9db1`](https://github.com/librespot-org/librespot/commit/4fd9db1fd9d04718b80d4aff072ca87a8fafcc89) ci: always include one tls backend - [`606f9dc`](https://github.com/librespot-org/librespot/commit/606f9dc4898d65fb3910adc97172e7853c8d65e6) refactor: TLS feature handling and CI build steps - [`2103965`](https://github.com/librespot-org/librespot/commit/2103965c25fa5b0dd18504fc6ec0a15bc6841530) refactor: document TLS backend options and propagate workspace fields ### 📊 Changes **31 files changed** (+928 additions, -577 deletions) <details> <summary>View changed files</summary> 📝 `.devcontainer/Dockerfile` (+0 -1) 📝 `.devcontainer/Dockerfile.alpine` (+0 -1) 📝 `.devcontainer/devcontainer.json` (+15 -19) ➕ `.github/workflows/build.yml` (+99 -0) ➕ `.github/workflows/cross-compile.yml` (+78 -0) ➕ `.github/workflows/quality.yml` (+79 -0) ➖ `.github/workflows/test.yml` (+0 -281) 📝 `CHANGELOG.md` (+1 -1) 📝 `COMPILING.md` (+65 -6) 📝 `Cargo.lock` (+190 -22) 📝 `Cargo.toml` (+147 -77) ➕ `Cross.toml` (+12 -0) 📝 `README.md` (+6 -4) 📝 `audio/Cargo.toml` (+15 -9) 📝 `audio/src/fetch/mod.rs` (+4 -6) 📝 `connect/Cargo.toml` (+17 -17) 📝 `core/Cargo.toml` (+44 -32) 📝 `core/src/http_client.rs` (+14 -9) 📝 `discovery/Cargo.toml` (+20 -16) 📝 `discovery/examples/discovery.rs` (+1 -1) _...and 11 more files_ </details> ### 📄 Description Maybe we're lucky and the latest Rust ecosystem is allowing us to switch to native TLS easily. This PR switches from rustls and ring to native TLS on all platforms. Fixes #1158 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:02:25 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1431

No description provided.

Rows
Columns