[PR #1523] [CLOSED] patch use of unresolvable CDN URLs #1427

New issue

Closed

opened 2026-02-27 20:02:24 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:02:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1523
Author: @KUHLwasStolen
Created: 8/2/2025
Status: ❌ Closed

Base: dev ← Head: lookup-cdn-simple

📝 Commits (4)

fa7fe9d add DNS lookup to try_get_url function to only return reachable URLs
456c536 move resolvability check to resolve_audio to execute it less often
b1e1117 follow contributing guideline and implement changes suggested by clippy
cea1a11 remove empty line and function documentation as suggested in review

📊 Changes

4 files changed (+38 additions, -1 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 Cargo.lock (+13 -0)
📝 core/Cargo.toml (+1 -0)
📝 core/src/cdn_url.rs (+23 -1)

📄 Description

This pull request adds a check to the resolve_audio function that checks the URLs via a DNS lookup. This is usually executed once per song.

As pointed out in this comment this patch is not an ideal solution, but until there is a better fix available I thought it can't hurt to suggest this, at least as a temporary patch.

I'm open to all sorts of suggestions and feedback on this PR.

closes #1521
closes #1522

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1523 **Author:** [@KUHLwasStolen](https://github.com/KUHLwasStolen) **Created:** 8/2/2025 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `lookup-cdn-simple` --- ### 📝 Commits (4) - [`fa7fe9d`](https://github.com/librespot-org/librespot/commit/fa7fe9df8ae975b0cdc382764a95dae5e2f453f5) add DNS lookup to try_get_url function to only return reachable URLs - [`456c536`](https://github.com/librespot-org/librespot/commit/456c5367841eff875770b441f26f88649d458856) move resolvability check to resolve_audio to execute it less often - [`b1e1117`](https://github.com/librespot-org/librespot/commit/b1e11179538b18c5d6a75cee054ec49705adbe9f) follow contributing guideline and implement changes suggested by clippy - [`cea1a11`](https://github.com/librespot-org/librespot/commit/cea1a11e5f0b6d0955f727e91cc4d26c3b3650f2) remove empty line and function documentation as suggested in review ### 📊 Changes **4 files changed** (+38 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `Cargo.lock` (+13 -0) 📝 `core/Cargo.toml` (+1 -0) 📝 `core/src/cdn_url.rs` (+23 -1) </details> ### 📄 Description This pull request adds a check to the `resolve_audio` function that checks the URLs via a DNS lookup. This is usually executed once per song. As pointed out in [this comment](https://github.com/librespot-org/librespot/issues/1521#issuecomment-3144170555) this patch is not an ideal solution, but until there is a better fix available I thought it can't hurt to suggest this, at least as a temporary patch. I'm open to all sorts of suggestions and feedback on this PR. closes #1521 closes #1522 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:02:24 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1427

No description provided.

Rows
Columns