starred/librespot

Fork 0

mirror of https://github.com/librespot-org/librespot.git synced 2026-04-27 08:15:50 +03:00

[GH-ISSUE #208] Get rid of Rust fmt #142

New issue

Closed

opened 2026-02-27 19:29:04 +03:00 by kerem · 2 comments

kerem commented

2026-02-27 19:29:04 +03:00

Owner

Originally created by @sashahilton00 on GitHub (Apr 24, 2018).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/208

Rust fmt does not seem to be as stable as we thought it was. I think it would be better if we just disable it on travis and wait for things to stabilse. The recommendation would still be to run rust fmt on commits, but it would mitigate these cases where PR's have to be updated due to formatting.

Originally created by @sashahilton00 on GitHub (Apr 24, 2018). Original GitHub issue: https://github.com/librespot-org/librespot/issues/208 Rust fmt does not seem to be as stable as we thought it was. I think it would be better if we just disable it on travis and wait for things to stabilse. The recommendation would still be to run rust fmt on commits, but it would mitigate these cases where PR's have to be updated due to formatting.

kerem closed this issue

2026-02-27 19:29:04 +03:00

kerem commented

2026-02-27 19:29:04 +03:00

Author

Owner

@plietar commented on GitHub (Apr 24, 2018):

I agree, this was a mistake. Sorry.

We could instead of requiring the entire codebase to be always properly formatted only require it for files which have been modified.

This can still cause issues, but less frequently than in today's situation. Ultimately we would want to only check the lines that have been touched by the PR, but rustfmt doesn't support this yet.

@plietar commented on GitHub (Apr 24, 2018): I agree, this was a mistake. Sorry. We could instead of requiring the entire codebase to be always properly formatted only require it for files which have been modified. This can still cause issues, but less frequently than in today's situation. Ultimately we would want to only check the lines that have been touched by the PR, but rustfmt doesn't support this yet.

kerem commented

2026-02-27 19:29:04 +03:00

Author

Owner

@sashahilton00 commented on GitHub (Apr 25, 2018):

Removed from travis in github.com/librespot-org/librespot@d76d9725e0

@sashahilton00 commented on GitHub (Apr 25, 2018): Removed from travis in https://github.com/librespot-org/librespot/commit/d76d9725e083648a628d6205296deb6ec6b984e6

kerem referenced this issue

2026-02-27 19:29:09 +03:00

[GH-ISSUE #229] Docker compile with pulseaudio backend fails #156

kerem referenced this issue

2026-02-27 19:29:09 +03:00

[GH-ISSUE #229] Docker compile with pulseaudio backend fails #156

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#142

No description provided.

Rows
Columns