[PR #1498] [MERGED] spirc: Configurable volume control steps #1419

New issue

Closed

opened 2026-02-27 20:02:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:02:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1498
Author: @ssmccoy
Created: 4/29/2025
Status: ✅ Merged
Merged: 5/1/2025
Merged by: @photovoltex

Base: dev ← Head: volume-steps

📝 Commits (7)

59728f6 spirc: Configurable volume control steps
66d0308 fixup! spirc: Configurable volume control steps
6572f8a fixup! spirc: Configurable volume control steps
0428c47 fixup! spirc: Configurable volume control steps
3501574 fixup! spirc: Configurable volume control steps
bd2e3e6 fixup! spirc: Configurable volume control steps
d95de5e fixup! spirc: Configurable volume control steps

📊 Changes

4 files changed (+54 additions, -23 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 connect/src/spirc.rs (+7 -5)
📝 connect/src/state.rs (+8 -2)
📝 src/main.rs (+38 -16)

📄 Description

Allow the volume control steps to be configured via the --volume-steps command line parameter. The author personally found the default volume steps of 1024 to be completely unusable, and is presently using 128 as his configuration. Updated the default to 64 which more closely mirrors the official client behavior.

Additionally, reduce the delay in volume update from a wopping two seconds to 500ms, again for usability.

Also clean up the seemingly unnecessary use of a pattern match on whether or not --initial-volume was supplied.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1498 **Author:** [@ssmccoy](https://github.com/ssmccoy) **Created:** 4/29/2025 **Status:** ✅ Merged **Merged:** 5/1/2025 **Merged by:** [@photovoltex](https://github.com/photovoltex) **Base:** `dev` ← **Head:** `volume-steps` --- ### 📝 Commits (7) - [`59728f6`](https://github.com/librespot-org/librespot/commit/59728f6f4d70cec0d691bd3df28b920463a0d2d8) spirc: Configurable volume control steps - [`66d0308`](https://github.com/librespot-org/librespot/commit/66d03086ead3794153661120e995cfe1d29e4bce) fixup! spirc: Configurable volume control steps - [`6572f8a`](https://github.com/librespot-org/librespot/commit/6572f8a18e445609c0b747d2fec4b43b78c00fab) fixup! spirc: Configurable volume control steps - [`0428c47`](https://github.com/librespot-org/librespot/commit/0428c4740bfaffb6564913a497bf3c82b70e0a8f) fixup! spirc: Configurable volume control steps - [`3501574`](https://github.com/librespot-org/librespot/commit/35015743a1f5f62eff06cc67d018ac87f4591f4b) fixup! spirc: Configurable volume control steps - [`bd2e3e6`](https://github.com/librespot-org/librespot/commit/bd2e3e606463f2fb4a6664345d318bae09476d9a) fixup! spirc: Configurable volume control steps - [`d95de5e`](https://github.com/librespot-org/librespot/commit/d95de5edeac2752c31117c35a82bc76e2285f9a5) fixup! spirc: Configurable volume control steps ### 📊 Changes **4 files changed** (+54 additions, -23 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `connect/src/spirc.rs` (+7 -5) 📝 `connect/src/state.rs` (+8 -2) 📝 `src/main.rs` (+38 -16) </details> ### 📄 Description Allow the volume control steps to be configured via the `--volume-steps` command line parameter. The author personally found the default volume steps of `1024` to be completely unusable, and is presently using `128` as his configuration. Updated the default to `64` which more closely mirrors the official client behavior. Additionally, reduce the delay in volume update from a wopping two seconds to 500ms, again for usability. Also clean up the seemingly unnecessary use of a pattern match on whether or not `--initial-volume` was supplied. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:02:22 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1419

No description provided.

Rows
Columns