[PR #1491] [MERGED] Mark unrelated parsing error as warning #1417

New issue

Closed

opened 2026-02-27 20:02:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:02:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1491
Author: @photovoltex
Created: 4/22/2025
Status: ✅ Merged
Merged: 5/3/2025
Merged by: @photovoltex

Base: dev ← Head: adjust-log-msg

📝 Commits (3)

af5444f mark known parsing error as warning
4c34c70 add copilot suggestion
474f126 adjust unknown enum handling for json

📊 Changes

4 files changed (+36 additions, -22 deletions)

View changed files

📝 connect/src/spirc.rs (+21 -4)
📝 core/src/dealer/mod.rs (+1 -1)
📝 core/src/dealer/protocol.rs (+13 -12)
📝 core/src/deserialize_with.rs (+1 -5)

📄 Description

The parsing error was multiple times falsely refereed to as possible cause, even tho it is completely unrelated to the main issue in most cases.

The issue will always happens when playing from an official player and then transferring the playback to librespot. The log message looked like the following:

[2025-04-20T09:14:08Z ERROR librespot_connect::spirc] could not parse session_update: Invalid state { Unknown enum variant name: WIFI_BROADCAST_CHANGED at 1:11 }

This change reduces the log level for the parsing failure for session_update to warn, while adding an additional message to highlight why it is only a warning.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1491 **Author:** [@photovoltex](https://github.com/photovoltex) **Created:** 4/22/2025 **Status:** ✅ Merged **Merged:** 5/3/2025 **Merged by:** [@photovoltex](https://github.com/photovoltex) **Base:** `dev` ← **Head:** `adjust-log-msg` --- ### 📝 Commits (3) - [`af5444f`](https://github.com/librespot-org/librespot/commit/af5444fc4af57eadf64adcb192cc1c421fafe4d7) mark known parsing error as warning - [`4c34c70`](https://github.com/librespot-org/librespot/commit/4c34c70dd1b375628953affade1134e688f89a81) add copilot suggestion - [`474f126`](https://github.com/librespot-org/librespot/commit/474f1268707f0816de292b6bfca2c81e3c8a65e6) adjust unknown enum handling for json ### 📊 Changes **4 files changed** (+36 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `connect/src/spirc.rs` (+21 -4) 📝 `core/src/dealer/mod.rs` (+1 -1) 📝 `core/src/dealer/protocol.rs` (+13 -12) 📝 `core/src/deserialize_with.rs` (+1 -5) </details> ### 📄 Description The parsing error was multiple times falsely refereed to as possible cause, even tho it is completely unrelated to the main issue in most cases. The issue will always happens when playing from an official player and then transferring the playback to `librespot`. The log message looked like the following: ``` [2025-04-20T09:14:08Z ERROR librespot_connect::spirc] could not parse session_update: Invalid state { Unknown enum variant name: WIFI_BROADCAST_CHANGED at 1:11 } ``` This change reduces the log level for the parsing failure for `session_update` to `warn`, while adding an additional message to highlight why it is only a warning. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:02:22 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1417

No description provided.

Rows
Columns