[PR #1458] [MERGED] core: include AP handshake in 5s timeout #1404

New issue

Closed

opened 2026-02-27 20:02:19 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:02:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1458
Author: @kingosticks
Created: 1/25/2025
Status: ✅ Merged
Merged: 1/28/2025
Merged by: @photovoltex

Base: dev ← Head: handshake-timeout

📝 Commits (2)

03ae423 core: include AP handshake in 5s timeout
24abeb2 Update CHANGELOG.md

📊 Changes

2 files changed (+9 additions, -5 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 core/src/connection/mod.rs (+8 -5)

📄 Description

Inspired by #1456.

I bumped the timeout to 5s since we're doing more work now. And added a debug message so can tell if it's the connect or the handshake that died.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1458 **Author:** [@kingosticks](https://github.com/kingosticks) **Created:** 1/25/2025 **Status:** ✅ Merged **Merged:** 1/28/2025 **Merged by:** [@photovoltex](https://github.com/photovoltex) **Base:** `dev` ← **Head:** `handshake-timeout` --- ### 📝 Commits (2) - [`03ae423`](https://github.com/librespot-org/librespot/commit/03ae4237405e8ab161cc6e705fd05d2df3032294) core: include AP handshake in 5s timeout - [`24abeb2`](https://github.com/librespot-org/librespot/commit/24abeb259b386e90d826d89fcd9ebc6c54e296cf) Update CHANGELOG.md ### 📊 Changes **2 files changed** (+9 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `core/src/connection/mod.rs` (+8 -5) </details> ### 📄 Description Inspired by #1456. I bumped the timeout to 5s since we're doing more work now. And added a debug message so can tell if it's the connect or the handshake that died. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:02:19 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1404

No description provided.

Rows
Columns