mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[GH-ISSUE #203] Crashes when connecting if playlist has local files #140
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#140
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @DragRedSim on GitHub (Apr 18, 2018).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/203
As briefly mentioned on the Gitter, https://gitter.im/librespot-org/spotify-connect-resources?at=5aa9807cf3f6d24c687603bf
I ran into this error myself today, running the volspotconnect2 plugin for Volumio, however felt it was more appropriate to report here since the error is not documented anywhere else, and the codebase used is from here, simply packaged for that platform.
When attempting to connect to the client, if a file local to the current player (from which is currently playing) is being played, the connection will fail and librespot will panic and fail. This also occurs if the controlling device attempts to change track, if one of the options is a local file.
Example log, from
sudo journalctl -f:I understand that there may not be a defined behaviour for this case in the protocol, however it would be better to handle such errors without crashing the entire librespot program if possible, even if it is by simply ignoring such files.
@ashthespy commented on GitHub (Nov 6, 2019):
https://github.com/librespot-org/librespot/pull/381/commits/508c7e2b260c041048373f12b33fca7702c4fe13 Should fix this: