[PR #1385] [MERGED] Get token with client #1370

New issue

Closed

opened 2026-02-27 20:02:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:02:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1385
Author: @fivebanger
Created: 10/29/2024
Status: ✅ Merged
Merged: 10/30/2024
Merged by: @roderickvd

Base: dev ← Head: get_token_with_client_id

📝 Commits (6)

52ce944 - get_token_with_client_id() added
9b64990 - get_token_with_client_id() added
29e797f - get_token_with_client_id() added
3a6848a - fixed clippy warnings
9037584 - comment added
8e1e6a4 fix typo

📊 Changes

2 files changed (+12 additions, -0 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 core/src/token.rs (+11 -0)

📄 Description

Fixes https://github.com/librespot-org/librespot/issues/1331

This PR fixes the issue for getting a token error when providing a specific combination of scopes and client_id. A new function get_token_with_client_id() was added to be able to provide a specific client_id when asking for a token.

The original get_token() function was kept in order to be fully backward compatible and not break any get_token() function call (for v0.5.0 and dev).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1385 **Author:** [@fivebanger](https://github.com/fivebanger) **Created:** 10/29/2024 **Status:** ✅ Merged **Merged:** 10/30/2024 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `get_token_with_client_id` --- ### 📝 Commits (6) - [`52ce944`](https://github.com/librespot-org/librespot/commit/52ce9449adbbfb19ebd72549ea0303b695c8652e) - get_token_with_client_id() added - [`9b64990`](https://github.com/librespot-org/librespot/commit/9b64990d323202ee5f1ece8c2b30c0e7b86fbffa) - get_token_with_client_id() added - [`29e797f`](https://github.com/librespot-org/librespot/commit/29e797fed43cbc2b4d120a6ffd6d327e78664b82) - get_token_with_client_id() added - [`3a6848a`](https://github.com/librespot-org/librespot/commit/3a6848ae2a9e19aea56db188298066f859af69c6) - fixed clippy warnings - [`9037584`](https://github.com/librespot-org/librespot/commit/90375840912c0a604f148c4453e7297b370fc6c9) - comment added - [`8e1e6a4`](https://github.com/librespot-org/librespot/commit/8e1e6a442381c47c7df02eb9db9169961a1edea3) fix typo ### 📊 Changes **2 files changed** (+12 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `core/src/token.rs` (+11 -0) </details> ### 📄 Description Fixes https://github.com/librespot-org/librespot/issues/1331 This PR fixes the issue for getting a token error when providing a specific combination of scopes and client_id. A new function `get_token_with_client_id()` was added to be able to provide a specific client_id when asking for a token. The original `get_token()` function was kept in order to be fully backward compatible and not break any get_token() function call (for v0.5.0 and dev). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:02:11 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1370

No description provided.

Rows
Columns