[PR #1366] [MERGED] Exposing service to both IPv4 and IPv6, addressing remaining issues from # #1364

Closed
opened 2026-02-27 20:02:10 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1366
Author: @ernstkl
Created: 10/6/2024
Status: Merged
Merged: 10/6/2024
Merged by: @roderickvd

Base: devHead: librespot-pr-1307-touch-up


📝 Commits (4)

  • 1eb3f55 Bind to both v4 and v6
  • 7b2e1ae Fix formatting (conflict resolved)
  • 514a280 create dual stack socket on non-windows systems only
  • 3204470 add entry to v0.5.0 changes

📊 Changes

2 files changed (+8 additions, -2 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 discovery/src/server.rs (+7 -2)

📄 Description

This is meant to address the remaining issues ("touch-up") in #1307, to get the changes ready for inclusion for release.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1366 **Author:** [@ernstkl](https://github.com/ernstkl) **Created:** 10/6/2024 **Status:** ✅ Merged **Merged:** 10/6/2024 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `librespot-pr-1307-touch-up` --- ### 📝 Commits (4) - [`1eb3f55`](https://github.com/librespot-org/librespot/commit/1eb3f5575875069226e51c855b71d05edbcdeed1) Bind to both v4 and v6 - [`7b2e1ae`](https://github.com/librespot-org/librespot/commit/7b2e1ae201f244c01a288ce82cff36cfa0e0384c) Fix formatting (conflict resolved) - [`514a280`](https://github.com/librespot-org/librespot/commit/514a280b8d4d199dde7179fd23a8a0102e417c68) create dual stack socket on non-windows systems only - [`3204470`](https://github.com/librespot-org/librespot/commit/3204470266e5c8a3d7938258bb43a00159073563) add entry to v0.5.0 changes ### 📊 Changes **2 files changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `discovery/src/server.rs` (+7 -2) </details> ### 📄 Description This is meant to address the remaining issues ("touch-up") in #1307, to get the changes ready for inclusion for release. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:02:10 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#1364
No description provided.