[PR #1339] [MERGED] Revert lint exception by setting minor version of protobuf #1344

New issue

Closed

opened 2026-02-27 20:02:05 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:02:05 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1339
Author: @yubiuser
Created: 9/16/2024
Status: ✅ Merged
Merged: 9/16/2024
Merged by: @roderickvd

Base: dev ← Head: restore/renamed_removed_lints

📝 Commits (2)

0ab9d59 Revert lint exception by setting minor version of protobuf
1859975 generate-lockfile

📊 Changes

8 files changed (+495 additions, -697 deletions)

View changed files

📝 .devcontainer/Dockerfile (+1 -1)
📝 .devcontainer/Dockerfile.alpine (+1 -1)
📝 .github/workflows/test.yml (+1 -1)
📝 Cargo.lock (+488 -690)
📝 connect/Cargo.toml (+1 -1)
📝 core/Cargo.toml (+1 -1)
📝 metadata/Cargo.toml (+1 -1)
📝 protocol/Cargo.toml (+1 -1)

📄 Description

Reverts the changes made in https://github.com/librespot-org/librespot/pull/1328.
Protobuff 3.5.1. fixed the underlying issue (https://github.com/stepancheg/rust-protobuf/pull/733). librespot already used version 3 of this create, but in the Cargo.lock it was set to 3.4.1. Specifying the minor version of the crate by 3.5 updated the Cargo.lock to use 3.5.1

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1339 **Author:** [@yubiuser](https://github.com/yubiuser) **Created:** 9/16/2024 **Status:** ✅ Merged **Merged:** 9/16/2024 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `restore/renamed_removed_lints` --- ### 📝 Commits (2) - [`0ab9d59`](https://github.com/librespot-org/librespot/commit/0ab9d591417f4605ed9dd42b4d94b48f027b85fd) Revert lint exception by setting minor version of protobuf - [`1859975`](https://github.com/librespot-org/librespot/commit/185997599f71609c0a83f17235001e5f0d58798a) generate-lockfile ### 📊 Changes **8 files changed** (+495 additions, -697 deletions) <details> <summary>View changed files</summary> 📝 `.devcontainer/Dockerfile` (+1 -1) 📝 `.devcontainer/Dockerfile.alpine` (+1 -1) 📝 `.github/workflows/test.yml` (+1 -1) 📝 `Cargo.lock` (+488 -690) 📝 `connect/Cargo.toml` (+1 -1) 📝 `core/Cargo.toml` (+1 -1) 📝 `metadata/Cargo.toml` (+1 -1) 📝 `protocol/Cargo.toml` (+1 -1) </details> ### 📄 Description Reverts the changes made in https://github.com/librespot-org/librespot/pull/1328. Protobuff 3.5.1. fixed the underlying issue (https://github.com/stepancheg/rust-protobuf/pull/733). `librespot` already used version `3` of this create, but in the `Cargo.lock` it was set to `3.4.1`. Specifying the minor version of the crate by `3.5` updated the `Cargo.lock` to use `3.5.1` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:02:05 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:02:06 +03:00

[PR #1344] [MERGED] Get access token via login5 #1347

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1344

No description provided.

Rows
Columns