_LINKER #1342

New issue

Closed

opened 2026-02-27 20:02:04 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:02:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1333
Author: @yubiuser
Created: 9/10/2024
Status: ✅ Merged
Merged: 9/13/2024
Merged by: @roderickvd

Base: dev ← Head: revert

📝 Commits (4)

5abcdbe Remove .cargo/config.toml and set link compiler on CI with CARGO_TARGET__LINKER
3f529c6 Run windows and cross builds parallel to linux tests
f2d6b25 Underscore
b3af5b4 Don't hard-code ${{ matrix.target }}

📊 Changes

3 files changed (+19 additions, -8 deletions)

View changed files

➖ .cargo/config.toml (+0 -3)
📝 .github/workflows/test.yml (+18 -5)
📝 .gitignore (+1 -0)

📄 Description

PR https://github.com/librespot-org/librespot/pull/1318 changed the workflow for cross-compiling from cross to nativ cargocross compiling. To set the correct linker, .cargo/config.toml was used. However, this has unexpected consequences for native builds on armv7 using another compiler. See github.com/librespot-org/librespot@78a8c61f85 (commitcomment-146451253)

This PR reverts the addition of .cargo/config.toml and sets the linker on CI with CARGO_TARGET_<triple>_LINKER env.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1333 **Author:** [@yubiuser](https://github.com/yubiuser) **Created:** 9/10/2024 **Status:** ✅ Merged **Merged:** 9/13/2024 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `revert` --- ### 📝 Commits (4) - [`5abcdbe`](https://github.com/librespot-org/librespot/commit/5abcdbe85d49ca796a003167d8aecd1267d2eb56) Remove .cargo/config.toml and set link compiler on CI with CARGO_TARGET_<triple>_LINKER - [`3f529c6`](https://github.com/librespot-org/librespot/commit/3f529c62d12966ce764ec5d5dee75b141e91e494) Run windows and cross builds parallel to linux tests - [`f2d6b25`](https://github.com/librespot-org/librespot/commit/f2d6b25f58e9dba9497fb3189ed5a4335d257d70) Underscore - [`b3af5b4`](https://github.com/librespot-org/librespot/commit/b3af5b463d393dc74264b232268cec51c459375e) Don't hard-code ${{ matrix.target }} ### 📊 Changes **3 files changed** (+19 additions, -8 deletions) <details> <summary>View changed files</summary> ➖ `.cargo/config.toml` (+0 -3) 📝 `.github/workflows/test.yml` (+18 -5) 📝 `.gitignore` (+1 -0) </details> ### 📄 Description PR https://github.com/librespot-org/librespot/pull/1318 changed the workflow for cross-compiling from `cross` to nativ `cargo`cross compiling. To set the correct linker, `.cargo/config.toml` was used. However, this has unexpected consequences for native builds on armv7 using another compiler. See https://github.com/librespot-org/librespot/commit/78a8c61f8544f57b46788e0458e36210d26b2bdb#commitcomment-146451253 This PR reverts the addition of `.cargo/config.toml` and sets the linker on CI with `CARGO_TARGET_<triple>_LINKER` env. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:02:04 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:02:05 +03:00

[PR #1342] [MERGED] Fix 96kbps playback issue (issues #1236) #1346

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1342

No description provided.

Rows
Columns