mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #1307] [CLOSED] Expose service to both IPv4 and IPv6 #1332
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#1332
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/1307
Author: @AndersBallegaard
Created: 7/16/2024
Status: ❌ Closed
Base:
dev← Head:dev📝 Commits (2)
378bdeaBind to both v4 and v6275da58Fix formatting📊 Changes
1 file changed (+3 additions, -2 deletions)
View changed files
📝
discovery/src/server.rs(+3 -2)📄 Description
Change to listen to [::0] given this will make the application listen on both ipv4 and ipv6. This is useful to enable support for ipv6 only networks.
Given most users will be on v4 only or dual stacked networks it is of course important to make sure that works, in my testing i have not found any case where this change created a problem for those devices.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.