mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #1302] [MERGED] add flag to display connect device as group #1329
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#1329
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/1302
Author: @JoeyEamigh
Created: 6/16/2024
Status: ✅ Merged
Merged: 6/17/2024
Merged by: @roderickvd
Base:
dev← Head:add-group-flag📝 Commits (1)
180ffacadding flag to show connect device as group📊 Changes
5 files changed (+49 additions, -1 deletions)
View changed files
📝
connect/src/config.rs(+2 -0)➕
discovery/examples/discovery_group.rs(+22 -0)📝
discovery/src/lib.rs(+7 -0)📝
discovery/src/server.rs(+9 -1)📝
src/main.rs(+9 -0)📄 Description
This PR adds support for the
groupStatusflag of the Spotify ZeroConf API and a flag in the CLI to set it.Motivation:
This allows differentiating between single and group devices when you have multiple Librespot instances or Connect devices on your network.
Notes:
The ZeroConf docs show
GROUPandNONEas valid options forgroupStatus.There was no obvious short flag to set for the new
groupflag, so no short flag was set.Verifying:
The new example at
discovery/discovery_group.rs.The command
cargo run -- --name "Librespot Group" --group.Example:

Let me know if you would like any changes!
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.