mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #1297] [MERGED] Fix building Docker image for cross-compilation [dev branch] #1324
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#1324
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/1297
Author: @starypatyk
Created: 6/9/2024
Status: ✅ Merged
Merged: 6/10/2024
Merged by: @roderickvd
Base:
dev← Head:dev-docker-build📝 Commits (1)
799bc38Fix building Docker image for cross-compilation:📊 Changes
1 file changed (+5 additions, -1 deletions)
View changed files
📝
contrib/Dockerfile(+5 -1)📄 Description
The changes to the Docker build made for the
old-apibranch in #1289 are also required in thedevbranch.Changes cherry-picked from the original commit.
With these changes I have been able to build the
devbranch for all architectures except MIPS.Does it still make sense to maintain the MIPS architecture? Are there any known uses of librespot on MIPS devices?
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.