[PR #1270] [MERGED] Fix clippy warnings #1311

New issue

Closed

opened 2026-02-27 20:01:58 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1270
Author: @yubiuser
Created: 3/31/2024
Status: ✅ Merged
Merged: 5/11/2024
Merged by: @roderickvd

Base: dev ← Head: fix/clippy

📝 Commits (2)

2cd2346 Fix map_clone and explicit truncate when file is create
63e2490 Fix redundant import checking on beta toolchain

📊 Changes

22 files changed (+10 additions, -38 deletions)

View changed files

📝 connect/src/spirc.rs (+1 -2)
📝 core/src/cdn_url.rs (+1 -4)
📝 core/src/connection/handshake.rs (+1 -1)
📝 core/src/connection/mod.rs (+1 -1)
📝 core/src/date.rs (+1 -1)
📝 core/src/session.rs (+1 -7)
📝 core/src/spotify_id.rs (+1 -5)
📝 metadata/src/album.rs (+0 -1)
📝 metadata/src/artist.rs (+0 -1)
📝 metadata/src/availability.rs (+0 -1)
📝 metadata/src/episode.rs (+0 -1)
📝 metadata/src/image.rs (+0 -1)
📝 metadata/src/playlist/annotation.rs (+0 -1)
📝 metadata/src/playlist/attribute.rs (+0 -1)
📝 metadata/src/playlist/diff.rs (+1 -1)
📝 metadata/src/playlist/item.rs (+0 -1)
📝 metadata/src/playlist/list.rs (+0 -1)
📝 metadata/src/playlist/operation.rs (+0 -1)
📝 metadata/src/sale_period.rs (+0 -1)
📝 metadata/src/show.rs (+1 -4)

...and 2 more files

📄 Description

Fixes a clippy warning that occured in recent tests regarding map_clone (https://rust-lang.github.io/rust-clippy/master/index.html#/map_clone) and file creation without explicite defining truncation behavior (https://rust-lang.github.io/rust-clippy/master/index.html#/suspicious_open_options)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1270 **Author:** [@yubiuser](https://github.com/yubiuser) **Created:** 3/31/2024 **Status:** ✅ Merged **Merged:** 5/11/2024 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `fix/clippy` --- ### 📝 Commits (2) - [`2cd2346`](https://github.com/librespot-org/librespot/commit/2cd2346edb71c3353feef005b080968f8f141ccb) Fix map_clone and explicit truncate when file is create - [`63e2490`](https://github.com/librespot-org/librespot/commit/63e249082113469f1c3d28174185d38124b44eda) Fix redundant import checking on beta toolchain ### 📊 Changes **22 files changed** (+10 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `connect/src/spirc.rs` (+1 -2) 📝 `core/src/cdn_url.rs` (+1 -4) 📝 `core/src/connection/handshake.rs` (+1 -1) 📝 `core/src/connection/mod.rs` (+1 -1) 📝 `core/src/date.rs` (+1 -1) 📝 `core/src/session.rs` (+1 -7) 📝 `core/src/spotify_id.rs` (+1 -5) 📝 `metadata/src/album.rs` (+0 -1) 📝 `metadata/src/artist.rs` (+0 -1) 📝 `metadata/src/availability.rs` (+0 -1) 📝 `metadata/src/episode.rs` (+0 -1) 📝 `metadata/src/image.rs` (+0 -1) 📝 `metadata/src/playlist/annotation.rs` (+0 -1) 📝 `metadata/src/playlist/attribute.rs` (+0 -1) 📝 `metadata/src/playlist/diff.rs` (+1 -1) 📝 `metadata/src/playlist/item.rs` (+0 -1) 📝 `metadata/src/playlist/list.rs` (+0 -1) 📝 `metadata/src/playlist/operation.rs` (+0 -1) 📝 `metadata/src/sale_period.rs` (+0 -1) 📝 `metadata/src/show.rs` (+1 -4) _...and 2 more files_ </details> ### 📄 Description Fixes a clippy warning that occured in [recent tests](https://github.com/librespot-org/librespot/actions/runs/8401256234/job/23275718451?pr=1269) regarding `map_clone` (https://rust-lang.github.io/rust-clippy/master/index.html#/map_clone) and file creation without explicite defining truncation behavior (https://rust-lang.github.io/rust-clippy/master/index.html#/suspicious_open_options) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:58 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1311

No description provided.

Rows
Columns