mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #1263] [MERGED] fix: working armv6hf docker image for cross-compiling #1305
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#1305
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/1263
Author: @gpajot
Created: 3/11/2024
Status: ✅ Merged
Merged: 3/31/2024
Merged by: @roderickvd
Base:
dev← Head:dev📝 Commits (1)
262fc2efix: working armv6hf docker image for cross-compiling📊 Changes
4 files changed (+64 additions, -24 deletions)
View changed files
📝
contrib/Dockerfile(+1 -7)➕
contrib/cross-compile-armv6hf/Dockerfile(+49 -0)➕
contrib/cross-compile-armv6hf/docker-build.sh(+14 -0)➖
contrib/docker-build-pi-armv6hf.sh(+0 -17)📄 Description
Hello, first off, thanks for this awesome repository!
The cross-compile docker image uses debian:strech for which apt repositories have been moved to archive. Since some packages have been marked as broken I could not find a way to keep using that image.
After using something very similar to what spotifyd is using I managed to have something working.
I have managed to compile successfully both from x86 and arm64 (M2), also confirming the resulting binary works on a Pi 1.
Ideally, something similar should probably be done for other architectures, though I don't have the means to test the compiled binaries.
If you are OK with this I can also update the wiki to reflect those changes.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.