[PR #1234] [MERGED] Make audio fetch parameters tunable #1294

New issue

Closed

opened 2026-02-27 20:01:54 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1234
Author: @lelloman
Created: 12/17/2023
Status: ✅ Merged
Merged: 12/24/2023
Merged by: @roderickvd

Base: dev ← Head: lelloman/tunable-audio-fetch-params

📝 Commits (1)

e175a88 Make audio fetch parameters tunable

📊 Changes

5 files changed (+99 additions, -59 deletions)

View changed files

📝 audio/src/fetch/mod.rs (+76 -38)
📝 audio/src/fetch/receive.rs (+17 -12)
📝 audio/src/lib.rs (+1 -2)
📝 playback/src/decoder/symphonia_decoder.rs (+1 -1)
📝 playback/src/player.rs (+4 -6)

📄 Description

This change collects all those audio fetch parameters that were defined as static constants into a dedicated struct, AudioFetchParams. This struct can be read and set statically, allowing a user of the library to modify those parameters without the need to recompile.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1234 **Author:** [@lelloman](https://github.com/lelloman) **Created:** 12/17/2023 **Status:** ✅ Merged **Merged:** 12/24/2023 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `lelloman/tunable-audio-fetch-params` --- ### 📝 Commits (1) - [`e175a88`](https://github.com/librespot-org/librespot/commit/e175a88f5bc27589c93e97ba33278a9838236920) Make audio fetch parameters tunable ### 📊 Changes **5 files changed** (+99 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `audio/src/fetch/mod.rs` (+76 -38) 📝 `audio/src/fetch/receive.rs` (+17 -12) 📝 `audio/src/lib.rs` (+1 -2) 📝 `playback/src/decoder/symphonia_decoder.rs` (+1 -1) 📝 `playback/src/player.rs` (+4 -6) </details> ### 📄 Description This change collects all those audio fetch parameters that were defined as static constants into a dedicated struct, AudioFetchParams. This struct can be read and set statically, allowing a user of the library to modify those parameters without the need to recompile. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:54 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:02:00 +03:00

[PR #1294] [CLOSED] Fix tokio tungstenite with pin tokio tungstenite ver 0.22.0 #1322

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1294

No description provided.

Rows
Columns