mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #1220] [CLOSED] Kingosticks change: Obtain spclient access token using login5 instead of keymaster (Fixes librespot-org#1179) #1282
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#1282
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/1220
Author: @Gerrelt
Created: 11/13/2023
Status: ❌ Closed
Base:
dev← Head:auth-token-from-login5📝 Commits (7)
96e02fdKingosticks change: Obtain spclient access token using login5 instead of keymaster (Fixes librespot-org#1179)ba08273Kingosticks change: Obtain spclient access token using login5 instead of keymaster (Fixes librespot-org#1179)f065908Merge branch 'librespot-org:dev' into auth-token-from-login5a54cc8fMerge branch 'librespot-org:dev' into auth-token-from-login5f815318Kingosticks change: Obtain spclient access token using login5 instead of keymaster (Fixes librespot-org#1179)40c2a4dMerge branch 'librespot-org:dev' into auth-token-from-login587dddf2Merge branch 'auth-token-from-login5' of https://github.com/Gerrelt/librespot into auth-token-from-login5📊 Changes
3 files changed (+111 additions, -12 deletions)
View changed files
📝
core/src/session.rs(+10 -0)📝
core/src/spclient.rs(+94 -12)📝
protocol/build.rs(+7 -0)📄 Description
See issue ccomment:
https://github.com/librespot-org/librespot/issues/1179#issuecomment-1704709439
@kingosticks asked if somebody else wanted to create the pull-request.
I've added the changes to the latest dev branch of librespot, compiled and tested it on raspberry pi.
It seems to still solve the problem as addressed in issuee 1179, it's working fine.
But I just copied the changes from kingostick, so all the questions, and the honor ( :-) ) are for kingosticks!
This is my attempt at creating a pull request. I've only done it once before, so I hope it's done correctly.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.