[PR #1206] [CLOSED] Fix credential cache not being used, forcing re-authentication for every download #1277

Closed
opened 2026-02-27 20:01:50 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1206
Author: @Laiteux
Created: 9/28/2023
Status: Closed

Base: masterHead: master


📝 Commits (1)

  • ceab10f Fix credential cache not being used

📊 Changes

1 file changed (+29 additions, -3 deletions)

View changed files

📝 core/src/session.rs (+29 -3)

📄 Description

Fixes #1168!

This PR makes the cache work, reusing auth_data from the credential cache.

Even faster downloads now, since no authentication has to be done again every time.

This is my first time working with Rust at all, so please let me know if anything could/should have been done better (:


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1206 **Author:** [@Laiteux](https://github.com/Laiteux) **Created:** 9/28/2023 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`ceab10f`](https://github.com/librespot-org/librespot/commit/ceab10f01592205bb5dc44c395002a26388d0514) Fix credential cache not being used ### 📊 Changes **1 file changed** (+29 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `core/src/session.rs` (+29 -3) </details> ### 📄 Description Fixes #1168! This PR makes the cache work, reusing `auth_data` from the credential cache. Even faster downloads now, since no authentication has to be done again every time. This is my first time working with Rust at all, so please let me know if anything could/should have been done better (: --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:01:50 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#1277
No description provided.