[PR #1178] [MERGED] Discovery retry #1267

New issue

Closed

opened 2026-02-27 20:01:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1178
Author: @JasonLG1979
Created: 6/16/2023
Status: ✅ Merged
Merged: 6/30/2023
Merged by: @roderickvd

Base: dev ← Head: discovery-retry

📝 Commits (3)

aaed7d3 Discovery retry
483e19b Merge branch 'librespot-org:dev' into discovery-retry
b1de707 Address review comment

📊 Changes

4 files changed (+44 additions, -15 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 Cargo.lock (+1 -0)
📝 Cargo.toml (+1 -0)
📝 src/main.rs (+41 -15)

📄 Description

When started at boot as a service discovery may fail due to it trying to bind to interfaces before the network is actually up. This could be prevented in systemd by starting the service after network-online.target but it requires that a wait-online.service is also enabled which is not always the case since a wait-online.service can potentially hang the boot process until it times out in certain situations. This allows for discovery to retry every 10 secs in the 1st 60 secs of uptime before giving up thus papering over the issue and not holding up the boot process.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1178 **Author:** [@JasonLG1979](https://github.com/JasonLG1979) **Created:** 6/16/2023 **Status:** ✅ Merged **Merged:** 6/30/2023 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `discovery-retry` --- ### 📝 Commits (3) - [`aaed7d3`](https://github.com/librespot-org/librespot/commit/aaed7d37f9f4b698d723c7b32bd20b1760c51311) Discovery retry - [`483e19b`](https://github.com/librespot-org/librespot/commit/483e19be8724e102dc8fb16650109a0bc70f0806) Merge branch 'librespot-org:dev' into discovery-retry - [`b1de707`](https://github.com/librespot-org/librespot/commit/b1de70769ddc12b8e6fdbd3fd1cd9e3184ae34c3) Address review comment ### 📊 Changes **4 files changed** (+44 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `Cargo.lock` (+1 -0) 📝 `Cargo.toml` (+1 -0) 📝 `src/main.rs` (+41 -15) </details> ### 📄 Description When started at boot as a service discovery may fail due to it trying to bind to interfaces before the network is actually up. This could be prevented in systemd by starting the service after network-online.target but it requires that a wait-online.service is also enabled which is not always the case since a wait-online.service can potentially hang the boot process until it times out in certain situations. This allows for discovery to retry every 10 secs in the 1st 60 secs of uptime before giving up thus papering over the issue and not holding up the boot process. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:47 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:57 +03:00

[PR #1267] [MERGED] fix: change spotify version needed in clientoken to use semantic format #1309

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1267

No description provided.

Rows
Columns