[PR #1159] [MERGED] Respect disabled normalisation with maximum volume #1259

New issue

Closed

opened 2026-02-27 20:01:45 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1159
Author: @AER00
Created: 5/2/2023
Status: ✅ Merged
Merged: 5/6/2023
Merged by: @roderickvd

Base: dev ← Head: dev

📝 Commits (3)

9c0cdbd respect disabled normalisation with max volume
34530bd group normalisation disabled in one branch and fix formatting
0cf95c8 normalisation fix - changelog

📊 Changes

2 files changed (+6 additions, -3 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 playback/src/player.rs (+5 -3)

📄 Description

I've noticed an issue with my CPU usage on a really low end device while playing music with maximum volume. When volume is equal to 1.0 and normalisation is disabled the first condition failed (as it should) and librespot didn't check whether the normalisation was disabled anymore - it just normalised the song anyway using self.config.normalisation_method.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1159 **Author:** [@AER00](https://github.com/AER00) **Created:** 5/2/2023 **Status:** ✅ Merged **Merged:** 5/6/2023 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (3) - [`9c0cdbd`](https://github.com/librespot-org/librespot/commit/9c0cdbd38f1947bcd541a81c7fab0001c1ba7a7c) respect disabled normalisation with max volume - [`34530bd`](https://github.com/librespot-org/librespot/commit/34530bdc18d851e800406c951806f17888ef2f22) group normalisation disabled in one branch and fix formatting - [`0cf95c8`](https://github.com/librespot-org/librespot/commit/0cf95c8bbe46b47c918759f76e17511db989422d) normalisation fix - changelog ### 📊 Changes **2 files changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `playback/src/player.rs` (+5 -3) </details> ### 📄 Description I've noticed an issue with my CPU usage on a really low end device while playing music with maximum volume. When volume is equal to 1.0 and normalisation is disabled the first condition failed (as it should) and librespot didn't check whether the normalisation was disabled anymore - it just normalised the song anyway using self.config.normalisation_method. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:45 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1259

No description provided.

Rows
Columns