[PR #1156] [MERGED] Update quick-xml #1257

Closed
opened 2026-02-27 20:01:45 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1156
Author: @yubiuser
Created: 4/13/2023
Status: Merged
Merged: 4/14/2023
Merged by: @roderickvd

Base: devHead: update/quick_xml


📝 Commits (1)

📊 Changes

3 files changed (+22 additions, -24 deletions)

View changed files

📝 Cargo.lock (+17 -17)
📝 core/Cargo.toml (+1 -1)
📝 core/src/session.rs (+4 -6)

📄 Description

This is one of a series of PRs that will update dependencies not included in https://github.com/librespot-org/librespot/pull/1140.

This one updates quick_xml from v0.23 to v0.28

The method unescape_and_decode (here) was renamed to unescape (here) and now decodes first beore unescaping. The result changed from String to Cow<'a, str>


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1156 **Author:** [@yubiuser](https://github.com/yubiuser) **Created:** 4/13/2023 **Status:** ✅ Merged **Merged:** 4/14/2023 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `update/quick_xml` --- ### 📝 Commits (1) - [`d8547f1`](https://github.com/librespot-org/librespot/commit/d8547f176cefab178e79f4f2d9ceec5a4148a9aa) Update quick-xml ### 📊 Changes **3 files changed** (+22 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+17 -17) 📝 `core/Cargo.toml` (+1 -1) 📝 `core/src/session.rs` (+4 -6) </details> ### 📄 Description This is one of a series of PRs that will update dependencies not included in https://github.com/librespot-org/librespot/pull/1140. This one updates `quick_xml` from v0.23 to v0.28 The method `unescape_and_decode` ([here](https://docs.rs/quick-xml/0.23.0/quick_xml/events/struct.BytesText.html#method.unescape_and_decode)) was renamed to `unescape` ([here](https://docs.rs/quick-xml/0.28.2/quick_xml/events/struct.BytesText.html#method.unescape)) and now decodes first beore unescaping. The result changed from `String` to `Cow<'a, str>` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:01:45 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#1257
No description provided.