[PR #1150] [MERGED] Check formatting and linting first on workflow #1252

New issue

Closed

opened 2026-02-27 20:01:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1150
Author: @yubiuser
Created: 4/12/2023
Status: ✅ Merged
Merged: 6/1/2023
Merged by: @roderickvd

Base: dev ← Head: tweak/workflow_order

📝 Commits (1)

b8eed83 Check formatting and linting first on workflow

📊 Changes

1 file changed (+59 additions, -59 deletions)

View changed files

📝 .github/workflows/test.yml (+59 -59)

📄 Description

Running the test workflow is a time and resource consuming task - the workflow runs between 20 and 40 minutes. Currently, the heavy test (compiling and cross-compiling) run before the lighter linting and format checking. This follows the following reasoning:

The layering here is as follows, checking in priority from highest to lowest:

However, I think the order should be changed to check formatting and linting first:

It's very annoying to wait 40 minutes for the checks to see it failing during the last steps due to a minor formatting error.
Reduce computational costs (energy): check formatting takes only seconds, compiling up to 30 minutes. If there is any failure (formatting or compiling) we should fail fast to prevent unnecessary computation. Therefore the "faster" checks should be done first.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1150 **Author:** [@yubiuser](https://github.com/yubiuser) **Created:** 4/12/2023 **Status:** ✅ Merged **Merged:** 6/1/2023 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `tweak/workflow_order` --- ### 📝 Commits (1) - [`b8eed83`](https://github.com/librespot-org/librespot/commit/b8eed83d384f4c99c491e09b7f5de24502ff0763) Check formatting and linting first on workflow ### 📊 Changes **1 file changed** (+59 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+59 -59) </details> ### 📄 Description Running the test workflow is a time and resource consuming task - the workflow runs between 20 and 40 minutes. Currently, the heavy test (compiling and cross-compiling) run before the lighter linting and format checking. This follows the following reasoning: > The layering here is as follows, checking in priority from highest to lowest: However, I think the order should be changed to check formatting and linting first: 1. It's very annoying to wait 40 minutes for the checks to see it failing during the last steps due to a minor formatting error. 2. Reduce computational costs (energy): check formatting takes only seconds, compiling up to 30 minutes. If there is any failure (formatting or compiling) we should fail fast to prevent unnecessary computation. Therefore the "faster" checks should be done first. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:44 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1252

No description provided.

Rows
Columns