[PR #1034] [MERGED] Add minimum rust version #1200

Closed
opened 2026-02-27 20:01:33 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/1034
Author: @sqozz
Created: 8/1/2022
Status: Merged
Merged: 8/1/2022
Merged by: @roderickvd

Base: devHead: min_rust


📝 Commits (1)

📊 Changes

9 files changed (+8 additions, -2 deletions)

View changed files

📝 COMPILING.md (+0 -2)
📝 Cargo.toml (+1 -0)
📝 audio/Cargo.toml (+1 -0)
📝 connect/Cargo.toml (+1 -0)
📝 core/Cargo.toml (+1 -0)
📝 discovery/Cargo.toml (+1 -0)
📝 metadata/Cargo.toml (+1 -0)
📝 playback/Cargo.toml (+1 -0)
📝 protocol/Cargo.toml (+1 -0)

📄 Description

See also: https://github.com/librespot-org/librespot/issues/1033
This adds a nice error message in case the rust-version is too old to compile librespot:

$ cargo build --release
error: package `librespot v0.5.0-dev (/home/sqozz/git/librespot)` cannot be built because it requires rustc 1.62.2 or newer, while the currently active rustc version is 1.62.1

I tried 1.62.1 which also worked fine (just set it higher before to test the warning itself). It is the lowest rustc version available to me it might be possible 1.61.x works too but I've no way to verify this.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/1034 **Author:** [@sqozz](https://github.com/sqozz) **Created:** 8/1/2022 **Status:** ✅ Merged **Merged:** 8/1/2022 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `min_rust` --- ### 📝 Commits (1) - [`d09ee42`](https://github.com/librespot-org/librespot/commit/d09ee4206c9192e026158ed72cd8707e6eea60f1) Add minimum rust version ### 📊 Changes **9 files changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `COMPILING.md` (+0 -2) 📝 `Cargo.toml` (+1 -0) 📝 `audio/Cargo.toml` (+1 -0) 📝 `connect/Cargo.toml` (+1 -0) 📝 `core/Cargo.toml` (+1 -0) 📝 `discovery/Cargo.toml` (+1 -0) 📝 `metadata/Cargo.toml` (+1 -0) 📝 `playback/Cargo.toml` (+1 -0) 📝 `protocol/Cargo.toml` (+1 -0) </details> ### 📄 Description See also: https://github.com/librespot-org/librespot/issues/1033 This adds a nice error message in case the rust-version is too old to compile librespot: ``` $ cargo build --release error: package `librespot v0.5.0-dev (/home/sqozz/git/librespot)` cannot be built because it requires rustc 1.62.2 or newer, while the currently active rustc version is 1.62.1 ``` I tried 1.62.1 which also worked fine (just set it higher before to test the warning itself). It is the lowest rustc version available to me it might be possible 1.61.x works too but I've no way to verify this. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:01:33 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#1200
No description provided.