mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #1034] [MERGED] Add minimum rust version #1200
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#1200
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/1034
Author: @sqozz
Created: 8/1/2022
Status: ✅ Merged
Merged: 8/1/2022
Merged by: @roderickvd
Base:
dev← Head:min_rust📝 Commits (1)
d09ee42Add minimum rust version📊 Changes
9 files changed (+8 additions, -2 deletions)
View changed files
📝
COMPILING.md(+0 -2)📝
Cargo.toml(+1 -0)📝
audio/Cargo.toml(+1 -0)📝
connect/Cargo.toml(+1 -0)📝
core/Cargo.toml(+1 -0)📝
discovery/Cargo.toml(+1 -0)📝
metadata/Cargo.toml(+1 -0)📝
playback/Cargo.toml(+1 -0)📝
protocol/Cargo.toml(+1 -0)📄 Description
See also: https://github.com/librespot-org/librespot/issues/1033
This adds a nice error message in case the rust-version is too old to compile librespot:
I tried 1.62.1 which also worked fine (just set it higher before to test the warning itself). It is the lowest rustc version available to me it might be possible 1.61.x works too but I've no way to verify this.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.