mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 00:05:55 +03:00
[PR #1000] [MERGED] Bump libmdns to 0.7 #1180
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#1180
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/1000
Author: @Gnarflord
Created: 5/19/2022
Status: ✅ Merged
Merged: 5/19/2022
Merged by: @roderickvd
Base:
dev← Head:dev📝 Commits (1)
10c9a0fUse libmdns 0.7 to avoid packet 47 error📊 Changes
1 file changed (+1 additions, -1 deletions)
View changed files
📝
discovery/Cargo.toml(+1 -1)📄 Description
On my machine I'm getting spammed with warnings of this type:
This is because some devices in my network use mDNS to talk to each other, broadcasting messages to other mDNS devices like the machine running librespot. But this packet type 47 hasn't been implemented in libmdns, so the warning is printed.
As I use librespot as a systemd daemon all those messages end up in my journal and accumulate to >1000 warning per day. This warning has been fixed 11 days ago in libmdns (see https://github.com/librespot-org/libmdns/issues/19).
I've locally compiled with the new libmdns version 0.7 instead of 0.6 and the messages disappear, so the bug seems to be resolved
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.