[PR #995] [MERGED] Allow to override build_id with SOURCE_DATE_EPOCH #1177

Closed
opened 2026-02-27 20:01:28 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/995
Author: @bmwiedemann
Created: 5/2/2022
Status: Merged
Merged: 5/20/2022
Merged by: @roderickvd

Base: devHead: dev


📝 Commits (1)

  • 9de1f38 Allow to override build_id with SOURCE_DATE_EPOCH

📊 Changes

1 file changed (+12 additions, -5 deletions)

View changed files

📝 core/build.rs (+12 -5)

📄 Description

Allow to override LIBRESPOT_BUILD_ID with SOURCE_DATE_EPOCH
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

I had an earlier version that used StdRng::seed_from_u64(val.parse().unwrap()) but thought that the extra complexity would be disadvantageous.

This PR was done while working on reproducible builds for openSUSE.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/995 **Author:** [@bmwiedemann](https://github.com/bmwiedemann) **Created:** 5/2/2022 **Status:** ✅ Merged **Merged:** 5/20/2022 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (1) - [`9de1f38`](https://github.com/librespot-org/librespot/commit/9de1f38e926de827cf2f05b4d0e42600a568c384) Allow to override build_id with SOURCE_DATE_EPOCH ### 📊 Changes **1 file changed** (+12 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `core/build.rs` (+12 -5) </details> ### 📄 Description Allow to override `LIBRESPOT_BUILD_ID` with `SOURCE_DATE_EPOCH` in order to make builds reproducible. See https://reproducible-builds.org/ for why this is good and https://reproducible-builds.org/specs/source-date-epoch/ for the definition of this variable. I had an earlier version that used `StdRng::seed_from_u64(val.parse().unwrap())` but thought that the extra complexity would be disadvantageous. This PR was done while working on reproducible builds for openSUSE. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:01:28 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#1177
No description provided.