mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #995] [MERGED] Allow to override build_id with SOURCE_DATE_EPOCH #1177
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#1177
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/995
Author: @bmwiedemann
Created: 5/2/2022
Status: ✅ Merged
Merged: 5/20/2022
Merged by: @roderickvd
Base:
dev← Head:dev📝 Commits (1)
9de1f38Allow to override build_id with SOURCE_DATE_EPOCH📊 Changes
1 file changed (+12 additions, -5 deletions)
View changed files
📝
core/build.rs(+12 -5)📄 Description
Allow to override
LIBRESPOT_BUILD_IDwithSOURCE_DATE_EPOCHin order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.
I had an earlier version that used
StdRng::seed_from_u64(val.parse().unwrap())but thought that the extra complexity would be disadvantageous.This PR was done while working on reproducible builds for openSUSE.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.