mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #976] [MERGED] Set the PulseAudio name to match librespot's device name #1170
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#1170
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/976
Author: @JasonLG1979
Created: 3/8/2022
Status: ✅ Merged
Merged: 3/19/2022
Merged by: @roderickvd
Base:
dev← Head:pulseaudio-name📝 Commits (1)
e0e23c9Use the librespot name arg for the app name in the PulseAudio backend📊 Changes
3 files changed (+62 additions, -19 deletions)
View changed files
📝
CHANGELOG.md(+3 -0)📝
playback/src/audio_backend/pulseaudio.rs(+22 -19)📝
src/main.rs(+37 -0)📄 Description
This sets the name displayed by PulseAudio to
Librespot - Instance Nameif a name is given otherwiseLibrespot(the default name).librespot -n "Instance Name"Results in:This also sets the correct "role" to "music" as per the docs:
https://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/Developer/Clients/ApplicationProperties/
PA_PROP_MEDIA_ROLE
"This is a property of the actual streamed data, not so much the application"
Roles are used for policies, things like automatically muting a music player when a call comes in and whatnot.
For bonus points this also sets
PULSE_PROP_application.icon_nametoaudio-x-genericso that we get a nice icon in the PulseAudio settings by our name instead of a missing icon placeholder.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.