[PR #964] [MERGED] Update to GStreamer bindings version 0.18 and various cleanups to the GStreamer audio backend #1165

New issue

Closed

opened 2026-02-27 20:01:25 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:25 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/964
Author: @sdroege
Created: 2/3/2022
Status: ✅ Merged
Merged: 2/13/2022
Merged by: @roderickvd

Base: new-api ← Head: gst-0.18

📝 Commits (10+)

6a23594 Update GStreamer backend to 0.18
7db566d Don't manually go through all intermediate states when shutting down the GStreamer backend
fa07202 Don't initialize GStreamer twice
2ede631 Use less stringly-typed API for configuring the appsrc
88ea5d1 Create our own main context instead of stealing the default one
0fcbdcd Create GStreamer pipeline more explicitly instead of going via strings for everything
1bd3bf5 Add an audioresample element before the sink in case the sink doesn't support the sample rate
950f20f Remove unnecessary as_bytes() call
3391c8e Run the GStreamer backend through rustfmt
7d0514e Use a GStreamer bus sync handler instead of spawning a new thread with a mainloop

📊 Changes

5 files changed (+174 additions, -161 deletions)

View changed files

📝 .github/workflows/test.yml (+3 -3)
📝 COMPILING.md (+1 -1)
📝 Cargo.lock (+77 -81)
📝 playback/Cargo.toml (+5 -4)
📝 playback/src/audio_backend/gstreamer.rs (+88 -72)

📄 Description

See individual commits for details.

Previous discussion here: https://github.com/librespot-org/librespot/pull/961

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/964 **Author:** [@sdroege](https://github.com/sdroege) **Created:** 2/3/2022 **Status:** ✅ Merged **Merged:** 2/13/2022 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `new-api` ← **Head:** `gst-0.18` --- ### 📝 Commits (10+) - [`6a23594`](https://github.com/librespot-org/librespot/commit/6a235942ee412356b2697d13adb6bdf19660b5cd) Update GStreamer backend to 0.18 - [`7db566d`](https://github.com/librespot-org/librespot/commit/7db566d793211ee09426ccca69845d13af4a70bf) Don't manually go through all intermediate states when shutting down the GStreamer backend - [`fa07202`](https://github.com/librespot-org/librespot/commit/fa07202442cc8c0a4654d467ed0e8aa5904cca17) Don't initialize GStreamer twice - [`2ede631`](https://github.com/librespot-org/librespot/commit/2ede631da3271c14b414e56350c1f2da6888d351) Use less stringly-typed API for configuring the appsrc - [`88ea5d1`](https://github.com/librespot-org/librespot/commit/88ea5d116e86d4235eeec1d376214cabe2ea50fb) Create our own main context instead of stealing the default one - [`0fcbdcd`](https://github.com/librespot-org/librespot/commit/0fcbdcd12fc4fc8569399eb7481556e5e96e3471) Create GStreamer pipeline more explicitly instead of going via strings for everything - [`1bd3bf5`](https://github.com/librespot-org/librespot/commit/1bd3bf5e6a5a9923e2de2ce20a543adff32f9386) Add an audioresample element before the sink in case the sink doesn't support the sample rate - [`950f20f`](https://github.com/librespot-org/librespot/commit/950f20ffbc8ff7cfdd41cdec0a18abc143ccd218) Remove unnecessary as_bytes() call - [`3391c8e`](https://github.com/librespot-org/librespot/commit/3391c8e4e7cc292397b4525072fe2a91fad0c4bd) Run the GStreamer backend through rustfmt - [`7d0514e`](https://github.com/librespot-org/librespot/commit/7d0514e09f43d0ef8ef8b60ba4c34888200f090e) Use a GStreamer bus sync handler instead of spawning a new thread with a mainloop ### 📊 Changes **5 files changed** (+174 additions, -161 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+3 -3) 📝 `COMPILING.md` (+1 -1) 📝 `Cargo.lock` (+77 -81) 📝 `playback/Cargo.toml` (+5 -4) 📝 `playback/src/audio_backend/gstreamer.rs` (+88 -72) </details> ### 📄 Description See individual commits for details. Previous discussion here: https://github.com/librespot-org/librespot/pull/961 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:25 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:46 +03:00

[PR #1165] [MERGED] Read Normalisation Data in one go #1261

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1165

No description provided.

Rows
Columns