[PR #961] [CLOSED] Update to GStreamer bindings version 0.18 and various cleanups to the GStreamer audio backend #1163

New issue

Closed

opened 2026-02-27 20:01:24 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/961
Author: @sdroege
Created: 2/1/2022
Status: ❌ Closed

Base: new-api ← Head: gst-0.18

📝 Commits (10+)

56114fd Update GStreamer backend to 0.18
cb694aa Don't manually go through all intermediate states when shutting down the GStreamer backend
9035bce Don't initialize GStreamer twice
7cce1ae Use less stringly-typed API for configuring the appsrc
d5fc752 Create our own main context instead of stealing the default one
7ddf29e Create GStreamer pipeline more explicitly instead of going via strings for everything
4764b89 Add an audioresample element before the sink in case the sink doesn't support the sample rate
176aa45 Remove unnecessary as_bytes() call
7545bd4 Run the GStreamer backend through rustfmt
2ffd6f7 Use a GStreamer bus sync handler instead of spawning a new thread with a mainloop

📊 Changes

3 files changed (+169 additions, -157 deletions)

View changed files

📝 Cargo.lock (+77 -81)
📝 playback/Cargo.toml (+5 -4)
📝 playback/src/audio_backend/gstreamer.rs (+87 -72)

📄 Description

See individual commits for details.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/961 **Author:** [@sdroege](https://github.com/sdroege) **Created:** 2/1/2022 **Status:** ❌ Closed **Base:** `new-api` ← **Head:** `gst-0.18` --- ### 📝 Commits (10+) - [`56114fd`](https://github.com/librespot-org/librespot/commit/56114fd5bef21a6acc86d1a922516eb4863fbfaa) Update GStreamer backend to 0.18 - [`cb694aa`](https://github.com/librespot-org/librespot/commit/cb694aac608f9c1e91d9346dd11a736f2a232402) Don't manually go through all intermediate states when shutting down the GStreamer backend - [`9035bce`](https://github.com/librespot-org/librespot/commit/9035bcec72fe2c0352857c96536661900f73359c) Don't initialize GStreamer twice - [`7cce1ae`](https://github.com/librespot-org/librespot/commit/7cce1aec8f6b5aa412843f5ab747b1e19b023a47) Use less stringly-typed API for configuring the appsrc - [`d5fc752`](https://github.com/librespot-org/librespot/commit/d5fc752e8145227713df8923ce629402c80cc296) Create our own main context instead of stealing the default one - [`7ddf29e`](https://github.com/librespot-org/librespot/commit/7ddf29e05d140e62761e27b1b1d9e608a1606593) Create GStreamer pipeline more explicitly instead of going via strings for everything - [`4764b89`](https://github.com/librespot-org/librespot/commit/4764b89d7c6d337973e21d006fe1ac236d41d3a5) Add an audioresample element before the sink in case the sink doesn't support the sample rate - [`176aa45`](https://github.com/librespot-org/librespot/commit/176aa45bdcf782ad11221a0535b589304085c061) Remove unnecessary as_bytes() call - [`7545bd4`](https://github.com/librespot-org/librespot/commit/7545bd474750b6181606d105d9465127f2fa416f) Run the GStreamer backend through rustfmt - [`2ffd6f7`](https://github.com/librespot-org/librespot/commit/2ffd6f751611c0b70880779e8337722f68572e5e) Use a GStreamer bus sync handler instead of spawning a new thread with a mainloop ### 📊 Changes **3 files changed** (+169 additions, -157 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+77 -81) 📝 `playback/Cargo.toml` (+5 -4) 📝 `playback/src/audio_backend/gstreamer.rs` (+87 -72) </details> ### 📄 Description See individual commits for details. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:24 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:46 +03:00

[PR #1163] [CLOSED] Modularize Normalisation a bit #1263

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1163

No description provided.

Rows
Columns