[PR #950] [MERGED] Fix Alsa softvol linear mapping #1157

Closed
opened 2026-02-27 20:01:23 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/950
Author: @roderickvd
Created: 1/26/2022
Status: Merged
Merged: 1/27/2022
Merged by: @roderickvd

Base: devHead: fix-alsa-linear-softvol


📝 Commits (3)

  • 10254b7 Fix Alsa softvol linear mapping
  • 4ef971b Update changelog
  • f547195 Merge remote-tracking branch 'origin/dev' into fix-alsa-linear-softvol

📊 Changes

2 files changed (+14 additions, -2 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 playback/src/mixer/alsamixer.rs (+13 -2)

📄 Description

When --volume-range was set, that propagated to the mapped volume control, but not to the Alsa mixer itself. This caused incorrect mapped_to_linear calculations.

Fixes: #948


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/950 **Author:** [@roderickvd](https://github.com/roderickvd) **Created:** 1/26/2022 **Status:** ✅ Merged **Merged:** 1/27/2022 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `fix-alsa-linear-softvol` --- ### 📝 Commits (3) - [`10254b7`](https://github.com/librespot-org/librespot/commit/10254b7d40a2194b3c1dc6c9b46e9963b97a56e8) Fix Alsa softvol linear mapping - [`4ef971b`](https://github.com/librespot-org/librespot/commit/4ef971b00de0e94cd20336498bb0f277f439c2e3) Update changelog - [`f547195`](https://github.com/librespot-org/librespot/commit/f5471954fbab2c8f0221c8b961d50c4631586351) Merge remote-tracking branch 'origin/dev' into fix-alsa-linear-softvol ### 📊 Changes **2 files changed** (+14 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `playback/src/mixer/alsamixer.rs` (+13 -2) </details> ### 📄 Description When `--volume-range` was set, that propagated to the mapped volume control, but not to the Alsa mixer itself. This caused incorrect `mapped_to_linear` calculations. Fixes: #948 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:01:23 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#1157
No description provided.