[PR #940] [MERGED] Remove unsafe code #1153

New issue

Closed

opened 2026-02-27 20:01:22 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/940
Author: @JasonLG1979
Created: 1/20/2022
Status: ✅ Merged
Merged: 1/23/2022
Merged by: @roderickvd

Base: dev ← Head: remove-unsafe

📝 Commits (4)

fe48a4d Remove unsafe code
b6cb40c Update CHANGELOG
40124b8 Better error handling
804ecf9 Update CHANGELOG

📊 Changes

6 files changed (+295 additions, -150 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 core/src/cache.rs (+11 -6)
📝 core/src/spotify_id.rs (+15 -19)
📝 metadata/src/lib.rs (+168 -94)
📝 playback/src/player.rs (+5 -2)
📝 src/player_event_handler.rs (+95 -29)

📄 Description

As mentioned in https://github.com/librespot-org/librespot/discussions/917#discussioncomment-2007452.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/940 **Author:** [@JasonLG1979](https://github.com/JasonLG1979) **Created:** 1/20/2022 **Status:** ✅ Merged **Merged:** 1/23/2022 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `remove-unsafe` --- ### 📝 Commits (4) - [`fe48a4d`](https://github.com/librespot-org/librespot/commit/fe48a4d8fe743ddde1d751cdc13e2c6c37317040) Remove unsafe code - [`b6cb40c`](https://github.com/librespot-org/librespot/commit/b6cb40c1307673b6f87abc5a5c61bb6d18fea8ed) Update CHANGELOG - [`40124b8`](https://github.com/librespot-org/librespot/commit/40124b8ef1cff4d69e6b86154665a5ae3c12a53f) Better error handling - [`804ecf9`](https://github.com/librespot-org/librespot/commit/804ecf9b1e5300bd303376dfa3e5e4bd9d53bf31) Update CHANGELOG ### 📊 Changes **6 files changed** (+295 additions, -150 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `core/src/cache.rs` (+11 -6) 📝 `core/src/spotify_id.rs` (+15 -19) 📝 `metadata/src/lib.rs` (+168 -94) 📝 `playback/src/player.rs` (+5 -2) 📝 `src/player_event_handler.rs` (+95 -29) </details> ### 📄 Description As mentioned in https://github.com/librespot-org/librespot/discussions/917#discussioncomment-2007452. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:22 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:44 +03:00

[PR #1153] [MERGED] Update vergen #1254

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1153

No description provided.

Rows
Columns