[PR #920] [MERGED] Sink: pass ownership of the packet on write() #1143

New issue

Closed

opened 2026-02-27 20:01:19 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/920
Author: @gdesmott
Created: 12/29/2021
Status: ✅ Merged
Merged: 1/1/2022
Merged by: @roderickvd

Base: dev ← Head: write-own

📝 Commits (1)

f09be48 Sink: pass ownership of the packet on write()

📊 Changes

7 files changed (+17 additions, -16 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 playback/src/audio_backend/jackaudio.rs (+1 -1)
📝 playback/src/audio_backend/mod.rs (+8 -8)
📝 playback/src/audio_backend/portaudio.rs (+4 -4)
📝 playback/src/audio_backend/rodio.rs (+1 -1)
📝 playback/src/audio_backend/sdl.rs (+1 -1)
📝 playback/src/player.rs (+1 -1)

📄 Description

Prevent a copy if the implementation needs to keep the data around.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/920 **Author:** [@gdesmott](https://github.com/gdesmott) **Created:** 12/29/2021 **Status:** ✅ Merged **Merged:** 1/1/2022 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `write-own` --- ### 📝 Commits (1) - [`f09be48`](https://github.com/librespot-org/librespot/commit/f09be4850ed1c79dc77becdb103b97bbe6a26d48) Sink: pass ownership of the packet on write() ### 📊 Changes **7 files changed** (+17 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `playback/src/audio_backend/jackaudio.rs` (+1 -1) 📝 `playback/src/audio_backend/mod.rs` (+8 -8) 📝 `playback/src/audio_backend/portaudio.rs` (+4 -4) 📝 `playback/src/audio_backend/rodio.rs` (+1 -1) 📝 `playback/src/audio_backend/sdl.rs` (+1 -1) 📝 `playback/src/player.rs` (+1 -1) </details> ### 📄 Description Prevent a copy if the implementation needs to keep the data around. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:19 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1143

No description provided.

Rows
Columns