mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #896] [MERGED] Dynamic failable buffer sizing alsa-backend #1136
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#1136
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/896
Author: @JasonLG1979
Created: 11/29/2021
Status: ✅ Merged
Merged: 12/15/2021
Merged by: @roderickvd
Base:
dev← Head:dynamic-alsa-buffer📝 Commits (1)
d5efb8aDynamic failable buffer sizing alsa-backend📊 Changes
1 file changed (+174 additions, -13 deletions)
View changed files
📝
playback/src/audio_backend/alsa.rs(+174 -13)📄 Description
Dynamically set the alsa buffer and period based on the device's reported min/max buffer and period sizes. In the event of failure use the device's defaults.
This should have no effect on devices that allow for reasonable buffer and period sizes but would allow us to be more forgiving with less reasonable devices or configurations.
Closes: https://github.com/librespot-org/librespot/issues/895
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.