[PR #881] [CLOSED] Upstream LibreELEC patch #1129

Closed
opened 2026-02-27 20:01:16 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/881
Author: @simonpils
Created: 11/18/2021
Status: Closed

Base: devHead: libreelec-patch


📝 Commits (1)

📊 Changes

4 files changed (+30 additions, -0 deletions)

View changed files

📝 core/src/spotify_id.rs (+6 -0)
📝 playback/src/config.rs (+2 -0)
📝 playback/src/player.rs (+14 -0)
📝 src/main.rs (+8 -0)

📄 Description

Hello,
librespot for LibreELEC is patched to notify Kodi of playback start/stop.
I have updated the patch for librespot 0.1.6 to work for librespot of the dev branch.
Would it be possible to upstream this patch to librespot?
This commit is the best I can do with my limited knowledge of librespot and Rust.
I expect that this commit needs to be adapted to suit librespot coding conventions.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/881 **Author:** [@simonpils](https://github.com/simonpils) **Created:** 11/18/2021 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `libreelec-patch` --- ### 📝 Commits (1) - [`39fcbb8`](https://github.com/librespot-org/librespot/commit/39fcbb83260d38c078f4e07c44b0fcf4e15e94cc) LibreELEC patch ### 📊 Changes **4 files changed** (+30 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `core/src/spotify_id.rs` (+6 -0) 📝 `playback/src/config.rs` (+2 -0) 📝 `playback/src/player.rs` (+14 -0) 📝 `src/main.rs` (+8 -0) </details> ### 📄 Description Hello, librespot for LibreELEC is [patched to notify Kodi of playback start/stop](https://github.com/LibreELEC/LibreELEC.tv/blob/master/packages/addons/service/librespot/patches/librespot-01_notify_kodi.patch). I have updated the patch for librespot 0.1.6 to work for librespot of the dev branch. Would it be possible to upstream this patch to librespot? This commit is the best I can do with my limited knowledge of librespot and Rust. I expect that this commit needs to be adapted to suit librespot coding conventions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:01:16 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#1129
No description provided.