[PR #859] [MERGED] Fix behavior after last track of an album/playlist #1116

New issue

Closed

opened 2026-02-27 20:01:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/859
Author: @roderickvd
Created: 10/5/2021
Status: ✅ Merged
Merged: 10/13/2021
Merged by: @roderickvd

Base: dev ← Head: fix-album-play

📝 Commits (2)

289b4f9 Fix behavior after last track of an album/playlist
0f5d610 Revert 10 track history window

📊 Changes

2 files changed (+16 additions, -17 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 connect/src/spirc.rs (+15 -17)

📄 Description

When autoplay is disabled, then loop back to the first track instead of 10 tracks back. Continue or stop playing depending on the state of the repeat button.
When autoplay is enabled, then extend the playlist after the last track. #844 broke this such that the last track of an album or playlist was never played.

Fixes: #434

Note: when an album with more than 10 tracks is started over half-way, and autoplay is disabled, then librespot doesn't loop back to the first track but about 10 tracks back. This isn't correct of course, but not a regression either as this already was the case. For reasons unknown to me, Spotify sends a frame without all tracks in this case, so librespot can't know. I'm fine with this for the scope of this PR -- all is well now if an album is played from the start.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/859 **Author:** [@roderickvd](https://github.com/roderickvd) **Created:** 10/5/2021 **Status:** ✅ Merged **Merged:** 10/13/2021 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `fix-album-play` --- ### 📝 Commits (2) - [`289b4f9`](https://github.com/librespot-org/librespot/commit/289b4f9bcceeee1e046986ba3337f75e0eea320a) Fix behavior after last track of an album/playlist - [`0f5d610`](https://github.com/librespot-org/librespot/commit/0f5d610b4bc681ea9c956f5768ea1093620e9812) Revert 10 track history window ### 📊 Changes **2 files changed** (+16 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `connect/src/spirc.rs` (+15 -17) </details> ### 📄 Description * When autoplay is disabled, then loop back to the first track instead of 10 tracks back. Continue or stop playing depending on the state of the repeat button. * When autoplay is enabled, then extend the playlist *after* the last track. #844 broke this such that the last track of an album or playlist was never played. Fixes: #434 _Note:_ when an album with more than 10 tracks is started over half-way, and autoplay is disabled, then `librespot` doesn't loop back to the first track but about 10 tracks back. This isn't correct of course, but not a regression either as this already was the case. For reasons unknown to me, Spotify sends a frame without all tracks in this case, so `librespot` can't know. I'm fine with this for the scope of this PR -- all is well now if an album is played from the start. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:13 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1116

No description provided.

Rows
Columns