[PR #844] [MERGED] Add and default to "auto" normalisation type #1109

Closed
opened 2026-02-27 20:01:11 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/844
Author: @roderickvd
Created: 9/3/2021
Status: Merged
Merged: 9/20/2021
Merged by: @roderickvd

Base: devHead: auto-normalisation-type


📝 Commits (3)

  • ba27da9 Add and default to "auto" normalisation type
  • 0ca7261 Fix auto normalisation when file is already loaded
  • 5b63ef6 Return get_factor to NormalisationData

📊 Changes

6 files changed (+82 additions, -25 deletions)

View changed files

📝 CHANGELOG.md (+3 -1)
📝 audio/src/fetch/receive.rs (+2 -1)
📝 connect/src/spirc.rs (+10 -1)
📝 playback/src/config.rs (+4 -2)
📝 playback/src/player.rs (+62 -19)
📝 src/main.rs (+1 -1)

📄 Description

As discussed in #780, this adds an "auto" normalisation type, and makes it the default. This automatically picks the album or track ReplayGain values, depending on whether the current context is an album context or not.

When autoplay is enabled and the playlist is extended when an album reaches its end, then "auto" starts picking the track values until an album is put up again.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/844 **Author:** [@roderickvd](https://github.com/roderickvd) **Created:** 9/3/2021 **Status:** ✅ Merged **Merged:** 9/20/2021 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `auto-normalisation-type` --- ### 📝 Commits (3) - [`ba27da9`](https://github.com/librespot-org/librespot/commit/ba27da97f7c3f16e958d3d5cddbe3c7a24655acf) Add and default to "auto" normalisation type - [`0ca7261`](https://github.com/librespot-org/librespot/commit/0ca72611157006f3486f462b515cc93bd88f1bbe) Fix auto normalisation when file is already loaded - [`5b63ef6`](https://github.com/librespot-org/librespot/commit/5b63ef67bdd2f63dde64dbcfd025d803d2316019) Return `get_factor` to `NormalisationData` ### 📊 Changes **6 files changed** (+82 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+3 -1) 📝 `audio/src/fetch/receive.rs` (+2 -1) 📝 `connect/src/spirc.rs` (+10 -1) 📝 `playback/src/config.rs` (+4 -2) 📝 `playback/src/player.rs` (+62 -19) 📝 `src/main.rs` (+1 -1) </details> ### 📄 Description As discussed in #780, this adds an "auto" normalisation type, and makes it the default. This automatically picks the album or track ReplayGain values, depending on whether the current context is an album context or not. When autoplay is enabled and the playlist is extended when an album reaches its end, then "auto" starts picking the track values until an album is put up again. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:01:11 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#1109
No description provided.