mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[PR #844] [MERGED] Add and default to "auto" normalisation type #1109
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#1109
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/librespot-org/librespot/pull/844
Author: @roderickvd
Created: 9/3/2021
Status: ✅ Merged
Merged: 9/20/2021
Merged by: @roderickvd
Base:
dev← Head:auto-normalisation-type📝 Commits (3)
ba27da9Add and default to "auto" normalisation type0ca7261Fix auto normalisation when file is already loaded5b63ef6Returnget_factortoNormalisationData📊 Changes
6 files changed (+82 additions, -25 deletions)
View changed files
📝
CHANGELOG.md(+3 -1)📝
audio/src/fetch/receive.rs(+2 -1)📝
connect/src/spirc.rs(+10 -1)📝
playback/src/config.rs(+4 -2)📝
playback/src/player.rs(+62 -19)📝
src/main.rs(+1 -1)📄 Description
As discussed in #780, this adds an "auto" normalisation type, and makes it the default. This automatically picks the album or track ReplayGain values, depending on whether the current context is an album context or not.
When autoplay is enabled and the playlist is extended when an album reaches its end, then "auto" starts picking the track values until an album is put up again.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.