[PR #840] [MERGED] Attenuate after normalisation #1106

New issue

Closed

opened 2026-02-27 20:01:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/840
Author: @roderickvd
Created: 9/1/2021
Status: ✅ Merged
Merged: 9/2/2021
Merged by: @roderickvd

Base: dev ← Head: attenuate-last

📝 Commits (2)

7da4d0e Attenuate after normalisation
d8e35bf Remove clamping of float samples

📊 Changes

1 file changed (+4 additions, -13 deletions)

View changed files

📝 playback/src/player.rs (+4 -13)

📄 Description

This is a small change just to do things right: volume control should be the last in line, after normalisation and potentially other filters. In practice very few if any will notice.

At the same time I removed the clamping of floating point samples. It's not necessary, when converting to integer samples the conversion will saturate at the bounds (i.e. clip) anyway.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/840 **Author:** [@roderickvd](https://github.com/roderickvd) **Created:** 9/1/2021 **Status:** ✅ Merged **Merged:** 9/2/2021 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `attenuate-last` --- ### 📝 Commits (2) - [`7da4d0e`](https://github.com/librespot-org/librespot/commit/7da4d0e4730ecdc8fcf82c97f1bc466ddf28e8b3) Attenuate after normalisation - [`d8e35bf`](https://github.com/librespot-org/librespot/commit/d8e35bf0c4f9ee3909da276665ac1d9df8386e00) Remove clamping of float samples ### 📊 Changes **1 file changed** (+4 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `playback/src/player.rs` (+4 -13) </details> ### 📄 Description This is a small change just to do things right: volume control should be the last in line, after normalisation and potentially other filters. In practice very few if any will notice. At the same time I removed the clamping of floating point samples. It's not necessary, when converting to integer samples the conversion will saturate at the bounds (i.e. clip) anyway. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:11 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:53 +03:00

[PR #1229] [MERGED] discovery::server: fix startup log #1290

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1106

No description provided.

Rows
Columns