[PR #821] [MERGED] Fix Alsa mixer #1101

New issue

Closed

opened 2026-02-27 20:01:10 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:10 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/821
Author: @roderickvd
Created: 7/9/2021
Status: ✅ Merged
Merged: 8/31/2021
Merged by: @roderickvd

Base: dev ← Head: fix-alsa-mixer

📝 Commits (3)

4c00b19 Fix Alsa mixer
43a8b91 Revert name to softvol
c67e268 Improve Alsa mixer command-line options

📊 Changes

5 files changed (+93 additions, -41 deletions)

View changed files

📝 CHANGELOG.md (+4 -1)
📝 playback/src/mixer/alsamixer.rs (+8 -8)
📝 playback/src/mixer/mod.rs (+2 -2)
📝 playback/src/mixer/softmixer.rs (+1 -1)
📝 src/main.rs (+78 -29)

📄 Description

As @michaelherger pointed out on Gitter, the --mixer command line option was no longer evaluated.
This was caused by incorrect merging of diverging branches.

Also renamed command line options as follows, to be more specific and in line with mpd:

mixer-card to alsa-mixer-device
mixer-name to alsa-mixer-control
mixer-index to alsa-mixer-index

The old ones generate a deprecation warning and still work.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/821 **Author:** [@roderickvd](https://github.com/roderickvd) **Created:** 7/9/2021 **Status:** ✅ Merged **Merged:** 8/31/2021 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `fix-alsa-mixer` --- ### 📝 Commits (3) - [`4c00b19`](https://github.com/librespot-org/librespot/commit/4c00b19c29d1c29a528e332113f20a0ce9cdcb34) Fix Alsa mixer - [`43a8b91`](https://github.com/librespot-org/librespot/commit/43a8b91a3dd8715d777520810642503385e19a8f) Revert name to softvol - [`c67e268`](https://github.com/librespot-org/librespot/commit/c67e268dc8b9552e215271cce7bb638a3133b3a2) Improve Alsa mixer command-line options ### 📊 Changes **5 files changed** (+93 additions, -41 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+4 -1) 📝 `playback/src/mixer/alsamixer.rs` (+8 -8) 📝 `playback/src/mixer/mod.rs` (+2 -2) 📝 `playback/src/mixer/softmixer.rs` (+1 -1) 📝 `src/main.rs` (+78 -29) </details> ### 📄 Description As @michaelherger pointed out on Gitter, the `--mixer` command line option was no longer evaluated. This was caused by incorrect merging of diverging branches. Also renamed command line options as follows, to be more specific and in line with `mpd`: - `mixer-card` to `alsa-mixer-device` - `mixer-name` to `alsa-mixer-control` - `mixer-index` to `alsa-mixer-index` The old ones generate a deprecation warning and still work. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:10 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1101

No description provided.

Rows
Columns