[PR #814] [MERGED] make convert and decoder public as they are needed by Sink traits #1095

New issue

Closed

opened 2026-02-27 20:01:09 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:09 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/814
Author: @lrbalt
Created: 6/28/2021
Status: ✅ Merged
Merged: 6/30/2021
Merged by: @roderickvd

Base: dev ← Head: dev

📝 Commits (3)

bb21ee1 make convert and decoder public as they are needed by Sink traits
140518d update CHANGELOG
1ae0be8 Update CHANGELOG.md

📊 Changes

2 files changed (+3 additions, -2 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 playback/src/lib.rs (+2 -2)

📄 Description

the Sink traits use AudioPacket and Converter and these are currently not public. This prevents you to implement your own sink implementation. I need this to integrate Librespot in my own player

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/814 **Author:** [@lrbalt](https://github.com/lrbalt) **Created:** 6/28/2021 **Status:** ✅ Merged **Merged:** 6/30/2021 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `dev` --- ### 📝 Commits (3) - [`bb21ee1`](https://github.com/librespot-org/librespot/commit/bb21ee1e7d333b35abe6fe1cc65e874ee145ccf9) make convert and decoder public as they are needed by Sink traits - [`140518d`](https://github.com/librespot-org/librespot/commit/140518df37ab8d3ddcf87c0080f20ced9f16e2d6) update CHANGELOG - [`1ae0be8`](https://github.com/librespot-org/librespot/commit/1ae0be8db87eb269869fe347a3b2c04452875920) Update CHANGELOG.md ### 📊 Changes **2 files changed** (+3 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `playback/src/lib.rs` (+2 -2) </details> ### 📄 Description the Sink traits use AudioPacket and Converter and these are currently not public. This prevents you to implement your own sink implementation. I need this to integrate Librespot in my own player --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:09 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1095

No description provided.

Rows
Columns