[PR #813] [MERGED] Don't explicitly set the number of periods #1093

New issue

Closed

opened 2026-02-27 20:01:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/813
Author: @JasonLG1979
Created: 6/25/2021
Status: ✅ Merged
Merged: 6/25/2021
Merged by: @roderickvd

Base: dev ← Head: alsa_buffer_hot_fix

📝 Commits (1)

bb24778 Don't explicitly set the number of periods

📊 Changes

1 file changed (+4 additions, -5 deletions)

View changed files

📝 playback/src/audio_backend/alsa.rs (+4 -5)

📄 Description

Doing so on configs that have less than the 4 periods we were asking for caused a crash. Instead ask for a buffer time of 500ms.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/813 **Author:** [@JasonLG1979](https://github.com/JasonLG1979) **Created:** 6/25/2021 **Status:** ✅ Merged **Merged:** 6/25/2021 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `alsa_buffer_hot_fix` --- ### 📝 Commits (1) - [`bb24778`](https://github.com/librespot-org/librespot/commit/bb2477831ba1299f60bd4ca9957391fc72c62015) Don't explicitly set the number of periods ### 📊 Changes **1 file changed** (+4 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `playback/src/audio_backend/alsa.rs` (+4 -5) </details> ### 📄 Description Doing so on configs that have less than the 4 periods we were asking for caused a crash. Instead ask for a buffer time of 500ms. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:08 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1093

No description provided.

Rows
Columns