[PR #802] [MERGED] Better errors in pipe backend #1085

New issue

Closed

opened 2026-02-27 20:01:06 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/802
Author: @JasonLG1979
Created: 6/18/2021
Status: ✅ Merged
Merged: 6/19/2021
Merged by: @roderickvd

Base: dev ← Head: fix_pipe_backend

📝 Commits (4)

0bece0d Fix pipe backend
2466e0b Merge branch 'librespot-org:dev' into fix_pipe_backend
336e714 Fix clippy warning
586e864 Update change log

📊 Changes

2 files changed (+37 additions, -11 deletions)

View changed files

📝 CHANGELOG.md (+1 -1)
📝 playback/src/audio_backend/pipe.rs (+36 -10)

📄 Description

Move all code that can fail to start where errors can be returned to prevent a panic!
Replace unwrap

Another backend fix much the same as the PulseAudio backend fix combined with the ability to gracefully exit on error player in #797 this should about do it for for the whole "never panic!" idea as far as the pipe backend is concerned.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/802 **Author:** [@JasonLG1979](https://github.com/JasonLG1979) **Created:** 6/18/2021 **Status:** ✅ Merged **Merged:** 6/19/2021 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `fix_pipe_backend` --- ### 📝 Commits (4) - [`0bece0d`](https://github.com/librespot-org/librespot/commit/0bece0d867094d50e1252be7a4842085df6aaa10) Fix pipe backend - [`2466e0b`](https://github.com/librespot-org/librespot/commit/2466e0b3c1bc9c21b75b7a45c64fa25cdfecba31) Merge branch 'librespot-org:dev' into fix_pipe_backend - [`336e714`](https://github.com/librespot-org/librespot/commit/336e714dba4bb45f1e0d26fb0966efed8edca968) Fix clippy warning - [`586e864`](https://github.com/librespot-org/librespot/commit/586e864427162a056c58e49e114a8b78e3bc216d) Update change log ### 📊 Changes **2 files changed** (+37 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -1) 📝 `playback/src/audio_backend/pipe.rs` (+36 -10) </details> ### 📄 Description * Move all code that can fail to `start` where errors can be returned to prevent a panic! * Replace unwrap Another backend fix much the same as the PulseAudio backend fix combined with the ability to gracefully exit on error player in #797 this should about do it for for the whole "never panic!" idea as far as the pipe backend is concerned. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:06 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1085

No description provided.

Rows
Columns